Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requeue k8s reconcile loop after attempting to delete network #112

Conversation

smrz2001
Copy link
Collaborator

No description provided.

@smrz2001 smrz2001 requested a review from nathanielc November 29, 2023 19:34
@smrz2001 smrz2001 self-assigned this Nov 29, 2023
Copy link

linear bot commented Nov 29, 2023

WS1-1357 Requeue k8s reconcile loop after attempting to delete network

Hypothesis is that networks are lingering for longer than the configured TTL because the deletion could fail and then loop never gets rerun.

@smrz2001 smrz2001 enabled auto-merge December 1, 2023 14:38
Copy link
Collaborator

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, sorry I missed this.

@smrz2001 smrz2001 added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 77f15f2 Dec 1, 2023
5 checks passed
@smrz2001
Copy link
Collaborator Author

smrz2001 commented Dec 1, 2023

Looks great, sorry I missed this.

No worries, ty!

@smrz2001 smrz2001 deleted the feature/ws1-1357-requeue-k8s-reconcile-loop-after-attempting-to-delete branch December 1, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants