Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: Move metadata here from setup.py #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,40 @@
[build-system]
requires = ["setuptools", "wheel", "cython"]
build-backend = "setuptools.build_meta"
requires = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing the CI failure since Python 3.6 does not support setuptools > 60.10.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... do you plan to keep support for Python 3.6?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably drop support for 3.6, but would want to do that simultaneously for all of snappy's various components. I suggest changing to setuptools>=59.6 unless you're using some newer feature.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for metadata in pyproject.toml was added in setuptools 61 I think,
and the [tool.setuptools] section is out of beta only since 68.1.0.

There's no urgency here.

"setuptools>=61.2",
"cython",
]
build-backend = "setuptools.build_meta"

[project]
name = "spherogram"
description = "Spherical diagrams for 3-manifold topology"
authors = [
{name = "Marc Culler", email = "[email protected]"},
{name = "Nathan M. Dunfield", email = "[email protected]"},
]
dependencies = [
"decorator",
"knot_floer_homology>=1.2",
"networkx",
"snappy_manifolds>=1.1.2",
]
requires-python = ">=3"
readme = "README.rst"
license = {text = "GPLv2+"}
keywords = ["knot", "link", "SnapPy"]
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Science/Research",
"License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)",
"Operating System :: OS Independent",
"Programming Language :: C",
"Programming Language :: Python",
"Topic :: Scientific/Engineering :: Mathematics",
]
dynamic = ["version"]

[project.urls]
Homepage = "https://github.com/3-manifolds/Spherogram"

[tool.setuptools.dynamic]
version = {attr = "spherogram.version.version"}
34 changes: 1 addition & 33 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,22 +196,7 @@ def run(self):

# Main module

exec(open('spherogram_src/version.py').read())

# Get long description from README
long_description = open('README.rst').read()
long_description = long_description.split('==\n')[1]
long_description = long_description.split('\nDeveloped')[0]

install_requires = ['decorator', 'networkx',
'snappy_manifolds>=1.1.2', 'knot_floer_homology>=1.2']

setup( name = 'spherogram',
version = version,
install_requires = install_requires,
python_requires = '>=3',
dependency_links = [],
packages = ['spherogram', 'spherogram.links',
setup( packages = ['spherogram', 'spherogram.links',
'spherogram.links.test', 'spherogram.codecs',
'spherogram.dev', 'spherogram.dev.dev_jennet'],
package_dir = {'spherogram' : 'spherogram_src', 'spherogram.dev':'dev'},
Expand All @@ -223,21 +208,4 @@ def run(self):
'pip_install':SpherogramPipInstall,
},
zip_safe = False,

description= 'Spherical diagrams for 3-manifold topology',
long_description = long_description,
author = 'Marc Culler and Nathan M. Dunfield',
author_email = '[email protected], [email protected]',
license='GPLv2+',
url = 'https://github.com/3-manifolds/Spherogram',
classifiers = [
'Development Status :: 5 - Production/Stable',
'Intended Audience :: Science/Research',
'License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)',
'Operating System :: OS Independent',
'Programming Language :: C',
'Programming Language :: Python',
'Topic :: Scientific/Engineering :: Mathematics',
],
keywords = 'knot, link, SnapPy',
)
Loading