Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for E221,E222,E227,E228 to the linter and extend it to dev/ #53

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

fchapoton
Copy link
Contributor

this is

  • extending the linter checks to the dev/ folder
  • adding checks for E221, E222, E227 and E228 (all about spaces around operators)

@NathanDunfield
Copy link
Member

Looks like these errors are from building the the binary extension FXrays for Python 3.12, not your changes. But we should get everything working with Python 3.12 first to be sure, see #112.

@culler
Copy link
Member

culler commented Aug 13, 2023 via email

@fchapoton
Copy link
Contributor Author

so it this now ready to merge ?

@NathanDunfield
Copy link
Member

so it this now ready to merge ?

Probably. I think we've updated all the dependencies of spherogram to support Python 3.12, so try running the CI again. If t's all green, I'll merge.

@NathanDunfield NathanDunfield merged commit 4d0e825 into 3-manifolds:master Sep 10, 2023
11 checks passed
@fchapoton fchapoton deleted the more_linter_pep8_checks branch September 11, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants