fix(command): correct cli options type (#20)

2nthony · Jul 15, 2022 · 6081005 · 6081005
1 parent 72aa2da
commit 6081005
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 2 deletions.
diff --git a/src/args.ts b/src/args.ts
@@ -28,3 +28,15 @@ export function parseCliOptionsToGitArgs(
 
   return args;
 }
+
+export function correctCliOptionsType(
+  options: OptionalConfig & CAC["options"],
+) {
+  return Object.entries(options).reduce((val, pair) => {
+    const [k, v] = pair;
+    if (v === "true" || v === "false") {
+      val[k] = JSON.parse(v);
+    }
+    return val;
+  }, options);
+}
diff --git a/src/commands/config.ts b/src/commands/config.ts
@@ -7,6 +7,7 @@ import {
   defaultConfig,
 } from "../config";
 import { PluginApi } from "../types";
+import { correctCliOptionsType } from "../args";
 
 export const config: PluginApi = {
   extend(api) {
@@ -29,7 +30,8 @@ export const config: PluginApi = {
         }
 
         if (options.set) {
-          await writeUserConfig(options.set);
+          const correctTypedOptions = correctCliOptionsType(options.set);
+          await writeUserConfig(correctTypedOptions);
           await printConfig(options.set);
           return;
         }

diff --git a/test/args.test.ts b/test/args.test.ts
@@ -1,5 +1,5 @@
 import { describe, expect, test } from "vitest";
-import { parseCliOptionsToGitArgs } from "../src/args";
+import { correctCliOptionsType, parseCliOptionsToGitArgs } from "../src/args";
 import { defaultConfig } from "../src/config";
 
 describe("parse cli options to args", () => {
@@ -13,3 +13,21 @@ describe("parse cli options to args", () => {
     expect(args).toEqual(["--depth", 1]);
   });
 });
+
+describe("correct cli options type", () => {
+  test("boolean", () => {
+    expect(
+      correctCliOptionsType({
+        // @ts-ignore
+        shallow: "true",
+      }),
+    ).toEqual({ shallow: true });
+
+    expect(
+      correctCliOptionsType({
+        // @ts-ignore
+        shallow: "false",
+      }),
+    ).toEqual({ shallow: false });
+  });
+});