Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't explicitly generate proxy.secretToken #396

Merged
merged 1 commit into from
May 13, 2021

Conversation

yuvipanda
Copy link
Member

Thanks to
jupyterhub/zero-to-jupyterhub-k8s#1993,
proxy.secretToken is automatically generated :)

Thanks to
jupyterhub/zero-to-jupyterhub-k8s#1993,
proxy.secretToken is automatically generated :)
@damianavila
Copy link
Contributor

@yuvipanda, do you know if this was this already released?

@yuvipanda
Copy link
Member Author

Yep!

@damianavila
Copy link
Contributor

Accordingly to this page: https://jupyterhub.github.io/helm-chart/
0.11.1 was released on Jan 15 and the reference PR was merged on Jan 27.
What am I missing here?

@yuvipanda
Copy link
Member Author

@damianavila ah, so I like running closer to master :D If you look at hub-templates/basehub/Chart.yaml, you'll see that we're actually on 0.11.1-n277.h61b0e003, which was released on March 3 (according to https://jupyterhub.github.io/helm-chart/). It was updated last in f51325e, to bring in jupyterhub/zero-to-jupyterhub-k8s#2077 (which I consider a very critical fix).

@damianavila
Copy link
Contributor

ah, so I like running closer to master :D

Ah, so you like to run at the cutting edge 😛
Thanks for the clarification!

Copy link
Contributor

@damianavila damianavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@yuvipanda yuvipanda merged commit 2115c2a into 2i2c-org:master May 13, 2021
@yuvipanda
Copy link
Member Author

@damianavila Thanks :D More so than cutting edge, I think z2jh master is pretty stable, and we should find resources to help make releases more frequently - see jupyterhub/team-compass#384 and #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants