Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to deploy with external aws account #3594

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

AIDEA775
Copy link
Contributor

@AIDEA775 AIDEA775 commented Jan 9, 2024

I am creating a new page because I believe it doesn't fit well within the current pages and their sections.

Please let me know if it would be more suitable to place it on another page.

ref: #3527


📚 Documentation preview 📚: https://2i2c-pilot-hubs--3594.org.readthedocs.build/en/3594/

@AIDEA775 AIDEA775 requested a review from a team as a code owner January 9, 2024 16:32
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small rewording suggestions, but LGTM 🚀 Thanks @AIDEA775

docs/hub-deployment-guide/new-cluster/external-account.md Outdated Show resolved Hide resolved
docs/hub-deployment-guide/new-cluster/external-account.md Outdated Show resolved Hide resolved
docs/hub-deployment-guide/new-cluster/external-account.md Outdated Show resolved Hide resolved
@AIDEA775
Copy link
Contributor Author

Thanks for the suggestions @GeorgianaElena!

@AIDEA775 AIDEA775 merged commit b6846fb into 2i2c-org:master Jan 10, 2024
3 checks passed
@AIDEA775 AIDEA775 deleted the aws-external-account branch January 10, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants