openscapes/linked-earth: fix node sharing to fit on nodes perfectly #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this adjustment, we could not request a dedicated node via node share.
Without this adjustment, we could not request a dedicated node via node share.
|
Merging this PR will trigger the following deployment actions. Support and Staging deployments
Production deployments
|
pnasrat
approved these changes
Mar 13, 2023
💯 I have a Python script locally on my computer for now, but its such an actively deliberated topic still so I've not focused on getting it into this repo yet. |
|
Thank you for review efforts @pnasrat!!! |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/4404919553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that hasn't been reported yet I think. Its a bug related to requesting 101% or similar when we should request <100% of the allocatable memory for a node.
Like this, we account for the allocatable memory as reported by k8s for specific node types and provide 1 GiB of headroom for system pods on the node like kube-proxy etc.
Already deployed
I've tested this and it solves the issue of failing to start on the largest node share variant.
Related