Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping helm chart dependency versions: binderhub #2180

Merged
merged 13 commits into from
Oct 3, 2023

Conversation

2i2c-token-generator-bot[bot]
Copy link
Contributor

@2i2c-token-generator-bot 2i2c-token-generator-bot bot commented Feb 8, 2023

This Pull Request is bumping the dependencies of the binderhub chart to the following versions.

  • binderhub: 1.0.0-0.dev.git.3170.h84b1db9 -> 1.0.0-0.dev.git.3182.h5312a70

@pnasrat
Copy link
Contributor

pnasrat commented Mar 10, 2023

@consideRatio with your change in #2218 can this just be closed out?

@consideRatio
Copy link
Member

@consideRatio with your change in #2218 can this just be closed out?

This remains a relevant automation still after #2218. In that PR we stopped manually overriding and updating an image declared in the binderhub helm chart, while this PR is bumping that helm chart. The chart will come with reference to modern versions of the images we previously manually updated, so as long as the chart is updated we are good by sticking with its default image reference.

I don't think there is an active deployment of binderhub yet though, so I'm not merging this or closing it to avoid getting more and more PRs opened.

@damianavila
Copy link
Contributor

I don't think there is an active deployment of binderhub yet though, so I'm not merging this or closing it to avoid getting more and more PRs opened.

I think we now have one: https://github.com/2i2c-org/infrastructure/blob/master/config/clusters/2i2c/binder-staging.values.yaml.

@github-actions

This comment was marked as resolved.

@damianavila
Copy link
Contributor

What we should do with this one, @consideRatio and @yuvipanda, any further thoughts?

@consideRatio
Copy link
Member

I lack context of the binderhub chart in 2i2c-org/infrastructure. Is it actively used? If not, should we remove it?

@sgibson91
Copy link
Member

@yuvipanda
Copy link
Member

We have a staging one, and there's upcoming funding to run more. So I'll merge this.

@yuvipanda yuvipanda merged commit 5fe1378 into master Oct 3, 2023
33 checks passed
@yuvipanda yuvipanda deleted the bump-helm-deps/binderhub/MCDB branch October 3, 2023 17:40
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6396517674

@damianavila
Copy link
Contributor

Thanks everyone for the feedback and the resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

5 participants