Skip to content

Commit

Permalink
Merge pull request #14 from sgibson91/ensure-lowercase-fullname
Browse files Browse the repository at this point in the history
Some more fixes around naming conventions
sgibson91 authored Sep 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
2 parents 8ba94f9 + 0411db4 commit 19fbf29
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions gcpFilestoreBackups/templates/_helpers.tpl
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
Expand the name of the chart.
*/}}
{{- define "gcpFilestoreBackups.name" -}}
{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }}
{{- default .Chart.Name .Values.nameOverride | lower | trunc 63 | trimSuffix "-" }}
{{- end }}

{{/*
@@ -46,7 +46,7 @@ app.kubernetes.io/managed-by: {{ .Release.Service }}
Selector labels
*/}}
{{- define "gcpFilestoreBackups.selectorLabels" -}}
app.kubernetes.io/name: {{ include "gcpFilestoreBackups.name" . }}
app.kubernetes.io/name: {{ include "gcpFilestoreBackups.name" . | lower }}
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end }}

2 changes: 1 addition & 1 deletion gcpFilestoreBackups/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
serviceAccountName: {{ include "gcpFilestoreBackups.fullname" . }}
serviceAccountName: {{ include "gcpFilestoreBackups.serviceAccountName" . }}
automountServiceAccountToken: False
containers:
- name: {{ .Chart.Name }}

0 comments on commit 19fbf29

Please sign in to comment.