Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stat-receiver] Refactoring by styleguide #535

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

Efber
Copy link
Contributor

@Efber Efber commented Nov 12, 2024

Pull Request description

Changelog

  • Добавил logLevel + проброс в конфиг приложения
  • Добавил initializeTopics.enabled и topicsPrefix в values + описал

Issues

  • ONPREM-166

Breaking changes

  • initializeTopics renamed to initializeTopics.enabled

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@Efber Efber marked this pull request as ready for review November 14, 2024 10:04
@Efber Efber requested review from a team as code owners November 14, 2024 10:04
@Efber Efber merged commit 9fbcef5 into develop Nov 20, 2024
3 checks passed
@Efber Efber deleted the ONPREM-166-stat-receiver-refactoring branch November 20, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants