add chart for citylens-routes-api #495
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+927
to
+932
| postgres: | ||
| database: '' | ||
| timeout: 15 | ||
| commandTimeout: 30 | ||
| maxPoolSize: 30 | ||
| pooling: false |
There was a problem hiding this comment.
потерялись хосты, порты и т.д., и нужно переименовать по стайлгайду https://github.com/2gis/on-premise-helm-charts/blob/develop/styleguide.md#%D0%B8%D0%BC%D0%B5%D0%BD%D0%BE%D0%B2%D0%B0%D0%BD%D0%B8%D0%B5-%D0%BD%D0%B0%D1%81%D1%82%D1%80%D0%BE%D0%B5%D0%BA
postgres:
host: ''
port: 5432
name: ''
username: ''
password: ''
timeout: 15
commandTimeout: 30
maxPoolSize: 30
pooling: false
There was a problem hiding this comment.
Хосты порты и тд переиспользовали от Values
charts/citylens/values.yaml
Outdated
Comment on lines
934
to
939
| hangfire: | ||
| database: '' | ||
| timeout: 15 | ||
| commandTimeout: 30 | ||
| maxPoolSize: 30 | ||
| pooling: false |
There was a problem hiding this comment.
тут лучше сразу обозначить, что будет использоваться постгрес
hangfire:
postgres:
host: ''
port: 5432
name: ''
username: ''
password: ''
timeout: 15
commandTimeout: 30
maxPoolSize: 30
pooling: false
charts/citylens/values.yaml
Outdated
Comment on lines
1020
to
1032
| busConfig: | ||
| brokers: [] | ||
| securityInformation: | ||
| saslUsername: '' | ||
| saslPassword: '' | ||
| saslMechanism: '' | ||
| securityProtocol: '' | ||
| consumers: | ||
| appEvents: | ||
| topic: '' | ||
| groupId: '' | ||
| bufferSize: 100 | ||
| workersCount: 10 |
There was a problem hiding this comment.
…ens-routes-api # Conflicts: # charts/citylens/templates/helpers.tpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
Привет! Это драфтовый ПР чтобы согласовать структуру чарта citylens-routes-api.