Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONPREM-665] Add base64 encoded favicon to improve UI of the helm management tools #445

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

bakadevops
Copy link
Contributor

@bakadevops bakadevops commented May 31, 2024

Pull Request description

Changelog

This PR adds a base64 encoded favicon to the helm chart to enhance the UI of the helm management tools.

Issues

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

Ashigo and others added 13 commits May 6, 2024 16:36
* pro-ui: New external style manager config
* base wf

* fix

* update

* update

* update

* update

* update

* update

* clean

* clean

* minor documentation changes

---------

Co-authored-by: Dmitrii Moskalev <[email protected]>
* base wf

* fix

* update

* update

* update

* update

* update

* update

* clean

* clean

* minor documentation changes

* changing name

---------

Co-authored-by: Dmitrii Moskalev <[email protected]>
@endryhold
Copy link
Contributor

dgtt_icon_chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.