Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Switched to asset-packagist.org and remove vcs-driver-options #12

Closed
wants to merge 7 commits into from
Closed

Switched to asset-packagist.org and remove vcs-driver-options #12

wants to merge 7 commits into from

Conversation

bahirul
Copy link
Contributor

@bahirul bahirul commented Jul 24, 2017

Fix for this PR

@tonydspaniard
Copy link
Member

@bahirul wow! this is totally new for me and it goes against Yii proposed installation procedures (http://www.yiiframework.com/doc-2.0/guide-start-installation.html#installing-from-composer) That could lead forcing the users to install two plugins for assets.

Let me check your previous issue before doing this. Thank you very much for your PR and proposal.

@tonydspaniard
Copy link
Member

@bahirul have you check this? yiisoft/yii2#14324 (comment)

@bahirul
Copy link
Contributor Author

bahirul commented Jul 24, 2017

@tonydspaniard : yeah, i already check that.
But my propose is to use asset-packagist and remove vcs-driver-options that caused error.
Even i already have latest fxp.
You can close my PR 😃

Thanks

@tonydspaniard
Copy link
Member

@bahirul no please, thank you for taking your time to work on this repo.

@tonydspaniard
Copy link
Member

@bahirul do you mind reopen this PR? I would like to merge it. Thanks!

@pana1990
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants