Skip to content

Commit

Permalink
[refactor] 생성자 메소드 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
doyeoo committed Nov 26, 2023
1 parent 11bc13d commit a83abac
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,14 +1,22 @@
package sungdong29.backend.domain.mission.dto.response;

import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
import lombok.Setter;

import java.util.List;

@Getter
@Setter
@AllArgsConstructor
public class MissionsResponseDTO {
List<MissionResponseDTO> missions;

@Builder
private MissionsResponseDTO(List<MissionResponseDTO> missions) { this.missions=missions; };

public static MissionsResponseDTO from(List<MissionResponseDTO> missions) {
return MissionsResponseDTO.builder()
.missions(missions)
.build();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public MissionsResponseDTO findMissionsBySubPlaceId(Long subPlaceId) {
.stream()
.map(mission -> mapper.map(mission, MissionResponseDTO.class))
.collect(Collectors.toList());
return new MissionsResponseDTO(missionResponseDTOS);
return MissionsResponseDTO.from(missionResponseDTOS);
}

public void accomplishMission(UserDetails userDetails, Long missionId) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,24 @@
package sungdong29.backend.domain.subPlace.dto.response;

import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Getter;
import lombok.Setter;

import java.util.List;

@Getter
@Setter
@AllArgsConstructor
public class SubPlacesResponseDTO {
List<SubPlaceResponseDTO> subPlaces;

@Builder
private SubPlacesResponseDTO(List<SubPlaceResponseDTO> subPlaces) {
this.subPlaces = subPlaces;
}

public static SubPlacesResponseDTO from(List<SubPlaceResponseDTO> subPlaces) {
return SubPlacesResponseDTO.builder()
.subPlaces(subPlaces)
.build();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

@Service
@RequiredArgsConstructor
public class SubPlaceService {
public class SubPlaceService {

private final SubPlaceRepository subPlaceRepository;
private final ModelMapper mapper;
Expand All @@ -24,6 +24,6 @@ public SubPlacesResponseDTO findSubPlaces(Long placeId) {
.stream()
.map(subPlace -> mapper.map(subPlace, SubPlaceResponseDTO.class))
.collect(Collectors.toList());
return new SubPlacesResponseDTO(subPlaceResponseDTOS);
return SubPlacesResponseDTO.from(subPlaceResponseDTOS);
}
}

0 comments on commit a83abac

Please sign in to comment.