-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Modern Grade" mode #906
base: main
Are you sure you want to change the base?
Conversation
Remove getFall, getWait and getDas, add additional points for finesse combo and recalibrate spn_mult
darn I thought of master graded X before this but was too lazy to make it lol |
Idea requesting is closed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man all this reviewing is reminding me i really gotta clean up the original master graded code. this PR LGTM imo, I could probably improve it tho
dude, just replace all tabs with 4 spaces using ctrl+h. it ain't that hard |
Thanks for the tip! |
i haven't playtested this, been pretty busy recently |
hmm im not sure about the finesse combo level buff. the finesse detection algorithm isn't really meant for 20g. also if your finesse combo is over 31 then you can just spam singles to level up fast (1 piece placed + 1 based on line cleared + 2 bonus = 4 levels per line) which I don't think is intended. in comparison, clearing quads in regular master graded will yield 7 levels (1.75 levels per line). |
Thanks for the reply! Regarding this, I think making the finesse combo depends on the level or gravity would be the best solution. Also, can I know how to play test on Techmino? |
finesse in 20g is still very unreliable though. sometimes you're literally forced to make a move that triggers the finesse detection. also by playtesting I mean playing the mode and see which issues arise so you can just do that by playing the mode yourself. |
I think the solution for this would be not applying finesse points when the gravity is 20G.
And thanks for telling me how to playtest! |
Ok, I'll do it right away. |
Regarding the last review, I added several features and adjust some grading systems:
Anyways, thanks for the review! |
TGM (grades) is confusing since TGM is already a thing and is another blockstacking game: https://tetris.wiki/TGM |
I also have another idea: if you get all awesomes, then you enter into a "super-invis" roll where:
also maybe we should nerf the normal invis roll to only give 0.6x the current amount of grade points and make the super-invis roll give 1.2x the current amount of grade points |
In my mind, there are four options for the name of it:
What do you think? |
nah I don't think that's very good. maybe you should just make an "Infinity Master" or "Omega Master" grade at like TM+3 |
Omega sounds good, but if you shorten it you'll get "OM" which is similar to "MO" |
from my experience in the Master of Blocks community, it's actually shortened to omegaM instead of OM, since most people can't really type Greek letters |
ΩM can be used in game, so I'll use it as the grade. |
In the last commit, I resolved every conflicts between main and this version. |
other than that one thing the code looks good, I just need someone to playtest it. i might do it sometime but I'm busy rn |
I'll review it after playtesting |
I have played it one or two times and... Grade I got after that: S4 Maybe need tweaking? |
I will playtest later... |
I am too busy right now, need another reviewer |
I haven't played the mode yet, but I have a suggestion for expanding the grades: |
33e873c
to
4768df6
Compare
Modern Grade Mode
Modern Grade Mode: Grade mode with additional grading system for modern scoring elements.
Settings:
slowMark
is disabled.Wait and Fall and DAS is non-restricted.
Add AWSOME!! and FAULT!!!
Listed to be 2700, 2700, 2520, 2280, 2280, 1980, 1980, 1620, 1620, 0 (second*60)
Listed to be 7200, 5400, 5400, 4500, 4080, 4080, 3600, 3600, 3600, 3600 (second*60)
Internal grade system: Add spin multiplier(default: 1.0, name:spn_mult). Spins multiplies it to 1.5, minis multiplies it to 1.2, perfect clears multiplies it to 2.0 and half perfect clears multiplies it to 1.2.
Internal grade system is now can be calculated as
grade_points+(pts*cmb_mult*lvl_mult*spn_mult)
.Line/Level Counter: Spins without deleting lines rewards 1 additional point except when
D.pt+1>=D.target
spins with deleting lines rewards 2 additional points if B2B is more than 50 else rewards 1 additional points
minis with deleting lines rewards 1 additional point
perfect clears rewards 4 additional points and half perfect clears rewards 1 additional point.
Other settings are identical to the settings of Master Graded mode.