Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Modern Grade" mode #906

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

JackTriton
Copy link

@JackTriton JackTriton commented Jun 16, 2023

Modern Grade Mode

Modern Grade Mode: Grade mode with additional grading system for modern scoring elements.

Settings:

  • slowMark is disabled.

  • Wait and Fall and DAS is non-restricted.

  • Add AWSOME!! and FAULT!!!

    • AWSOME, competing 70 lines far more faster than COOL, gives you 2 cools
      Listed to be 2700, 2700, 2520, 2280, 2280, 1980, 1980, 1620, 1620, 0 (second*60)
    • FAULT, competing 100 lines much slower than REGRET, gives you 2 regrets
      Listed to be 7200, 5400, 5400, 4500, 4080, 4080, 3600, 3600, 3600, 3600 (second*60)
  • Internal grade system: Add spin multiplier(default: 1.0, name:spn_mult). Spins multiplies it to 1.5, minis multiplies it to 1.2, perfect clears multiplies it to 2.0 and half perfect clears multiplies it to 1.2.
    Internal grade system is now can be calculated as grade_points+(pts*cmb_mult*lvl_mult*spn_mult).

  • Line/Level Counter: Spins without deleting lines rewards 1 additional point except when D.pt+1>=D.target
    spins with deleting lines rewards 2 additional points if B2B is more than 50 else rewards 1 additional points
    minis with deleting lines rewards 1 additional point
    perfect clears rewards 4 additional points and half perfect clears rewards 1 additional point.

Other settings are identical to the settings of Master Graded mode.

@JackTriton JackTriton marked this pull request as draft June 20, 2023 02:51
Remove getFall, getWait and getDas, add additional points for finesse combo and recalibrate spn_mult
@Not-A-Normal-Robot
Copy link
Member

darn I thought of master graded X before this but was too lazy to make it lol

@JackTriton JackTriton marked this pull request as ready for review July 12, 2023 01:31
@JackTriton
Copy link
Author

Idea requesting is closed!
But that doesn’t mean I’ll ignore the glitches.
If there is, please contact me.

@MrZ626 MrZ626 self-requested a review July 17, 2023 02:18
@shoucandanghehe shoucandanghehe added the enhancement New feature or request label Aug 11, 2023
parts/eventsets/master_g_modern.lua Outdated Show resolved Hide resolved
parts/language/lang_en.lua Outdated Show resolved Hide resolved
Copy link
Member

@Not-A-Normal-Robot Not-A-Normal-Robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man all this reviewing is reminding me i really gotta clean up the original master graded code. this PR LGTM imo, I could probably improve it tho

@Not-A-Normal-Robot
Copy link
Member

dude, just replace all tabs with 4 spaces using ctrl+h. it ain't that hard

@JackTriton
Copy link
Author

JackTriton commented Sep 4, 2023

dude, just replace all tabs with 4 spaces using ctrl+h. it ain't that hard

Thanks for the tip!
I checked all of the file that I edited, and now all of the tabs are replaced with 4 spaces.

@Not-A-Normal-Robot
Copy link
Member

i haven't playtested this, been pretty busy recently

@Not-A-Normal-Robot
Copy link
Member

hmm im not sure about the finesse combo level buff. the finesse detection algorithm isn't really meant for 20g. also if your finesse combo is over 31 then you can just spam singles to level up fast (1 piece placed + 1 based on line cleared + 2 bonus = 4 levels per line) which I don't think is intended. in comparison, clearing quads in regular master graded will yield 7 levels (1.75 levels per line).

@JackTriton
Copy link
Author

JackTriton commented Sep 22, 2023

hmm im not sure about the finesse combo level buff. the finesse detection algorithm isn't really meant for 20g. also if your finesse combo is over 31 then you can just spam singles to level up fast (1 piece placed + 1 based on line cleared + 2 bonus = 4 levels per line) which I don't think is intended. in comparison, clearing quads in regular master graded will yield 7 levels (1.75 levels per line).

Thanks for the reply! Regarding this, I think making the finesse combo depends on the level or gravity would be the best solution.
ex). level1 - 5 >> 15 / 30 combos, level 6 - 10 >> 30 / 60 combos, level 11 - 15 >> 60 / 120 combos, level 16 - 120 / 360 combos
What do you think ?

Also, can I know how to play test on Techmino?

@Not-A-Normal-Robot
Copy link
Member

finesse in 20g is still very unreliable though. sometimes you're literally forced to make a move that triggers the finesse detection.

also by playtesting I mean playing the mode and see which issues arise so you can just do that by playing the mode yourself.

@JackTriton
Copy link
Author

JackTriton commented Sep 24, 2023

finesse in 20g is still very unreliable though. sometimes you're literally forced to make a move that triggers the finesse detection.

also by playtesting I mean playing the mode and see which issues arise so you can just do that by playing the mode yourself.

I think the solution for this would be not applying finesse points when the gravity is 20G.
So the new system for the finesse boost would be:

  • If the deleted lines are more than 650, you would not get any bonus points depending on finesse.
  • If the deleted lines are more than 450 and finesse is more than 360, you would get 1 bonus point.
  • If the deleted lines are more than 230, you would get 1 bonus point if finesse is more than 90, and 2 bonus points if finesse is more than 180.
  • If the deleted lines are more than 120, you would get 1 bonus point if finesse is more than 30, and 2 bonus points if finesse is more than 60.
  • Below that, you would get 1 bonus point if finesse is more than 15, and 2 bonus points if finesse is more than 30.

And thanks for telling me how to playtest!

@JackTriton
Copy link
Author

JackTriton commented Sep 25, 2023

also in a recent commit I refactored the entirety of master graded to make it cleaner 😬 I think you may have to redo it all again so the code isn't messy

Ok, I'll do it right away.

@Not-A-Normal-Robot
Copy link
Member

image
yeah i personally think this needs more rebalancing, TM+ in this mode seems easier than in the regular Master Graded mode, the game still seems very fast, and the max speed level happens too early.
most people coming from TGM kinda expect a little bit of entry delay but since this mode has no entry delay it may throw them off in later levels.
also people don't usually go for spins in TGM, so maybe it's only for speedrunners?

@JackTriton
Copy link
Author

JackTriton commented Oct 11, 2023

Regarding the last review, I added several features and adjust some grading systems:

  • Grading now has 10 (First Grade), S0 (Grade After S1), m0 (Grade After m1), TGM-, TGM(Tech Grand Master) and TGM+. (Grades which is successor of TM(Tech Master))
  • Leveling is more slower than traditional grading.
Speed level Internal Gravity Speed level Internal Gravity
0 64 200 2
30 43 240 64
40 32 260 8
50 26 270 4
60 21 290 3
70 16 320 2
80 8 370 1
90 6 430 0.5
120 4 510 0.25
160 3 600 0 = 20G
  • Invis Mode is applied after you get 11 cools.
  • IGB and Decay Rate is Elongated.
  • If you get AWESOME!!!, the speed will get faster than getting COOL!! (Speed + 150).
  • If you cleared lines more than 1400, the Lock will be 12.

Anyways, thanks for the review!

@Not-A-Normal-Robot
Copy link
Member

TGM (grades) is confusing since TGM is already a thing and is another blockstacking game: https://tetris.wiki/TGM

@Not-A-Normal-Robot
Copy link
Member

I also have another idea: if you get all awesomes, then you enter into a "super-invis" roll where:

  • current piece is hidden
  • lock FX is set to 3
  • obviously the field is invisible

also maybe we should nerf the normal invis roll to only give 0.6x the current amount of grade points and make the super-invis roll give 1.2x the current amount of grade points

@JackTriton
Copy link
Author

TGM (grades) is confusing since TGM is already a thing and is another blockstacking game: https://tetris.wiki/TGM

In my mind, there are four options for the name of it:

  1. GTM (Grand Tech Master)
  2. GMM (Grand Master of Master)
  3. AGM (Absolute Grand Master)

What do you think?

@Not-A-Normal-Robot
Copy link
Member

nah I don't think that's very good. maybe you should just make an "Infinity Master" or "Omega Master" grade at like TM+3

@JackTriton
Copy link
Author

nah I don't think that's very good. maybe you should just make an "Infinity Master" or "Omega Master" grade at like TM+3

Omega sounds good, but if you shorten it you'll get "OM" which is similar to "MO"
So I'll go with IM (Infinity Master).

@Not-A-Normal-Robot
Copy link
Member

Not-A-Normal-Robot commented Oct 13, 2023

from my experience in the Master of Blocks community, it's actually shortened to omegaM instead of OM, since most people can't really type Greek letters

@JackTriton
Copy link
Author

JackTriton commented Oct 13, 2023

ΩM can be used in game, so I'll use it as the grade.
∞M can be used and ΣM also can be used.
So I'll use ΩM(Ωmega Master), ΣM(Σigma Master) and ∞M(I∞finity Master) in this order.
After that, you'll get ∞M+.

@JackTriton
Copy link
Author

JackTriton commented Nov 21, 2023

In the last commit, I resolved every conflicts between main and this version.

parts/gameFuncs.lua Outdated Show resolved Hide resolved
@Not-A-Normal-Robot
Copy link
Member

other than that one thing the code looks good, I just need someone to playtest it. i might do it sometime but I'm busy rn

@Not-A-Normal-Robot
Copy link
Member

I'll review it after playtesting

@SweetSea-ButImNotSweet
Copy link
Contributor

I have played it one or two times and...
To be honest, the speed jump when level up to 600 (or 500?) is too fast, like I can't keep up with the speed gap

Grade I got after that: S4

Maybe need tweaking?

@SweetSea-ButImNotSweet
Copy link
Contributor

I will playtest later...

parts/modes.lua Outdated Show resolved Hide resolved
parts/gameFuncs.lua Outdated Show resolved Hide resolved
parts/eventsets/master_g_modern.lua Show resolved Hide resolved
@SweetSea-ButImNotSweet
Copy link
Contributor

I am too busy right now, need another reviewer

@stockfishcooker
Copy link

I haven't played the mode yet, but I have a suggestion for expanding the grades:
After m9, instead of jumping straight to Master, we can go mS1 instead (master S1).
From mS1 (mS0) to mS9 will grant you 9 to 10 grades, more than enough to keep TM+ the highest grade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants