Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test custom attack effect #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test custom attack effect #561

wants to merge 1 commit into from
+10 −19

Conversation

flaribbit
Copy link
Member

@flaribbit flaribbit commented Dec 21, 2021 •
edited
Loading

2021-12-21.23-54-33.mp4

@flaribbit flaribbit added the hang on Don't resolve/close this for now label Dec 21, 2021
@Not-A-Normal-Robot
Copy link
Member

it looks good enough but let's wait until OP tells us it's ready before it's merged

Not-A-Normal-Robot
Not-A-Normal-Robot approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@Not-A-Normal-Robot Not-A-Normal-Robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I like this

@Not-A-Normal-Robot
Copy link
Member

image
A lot of people like this ✅

@Not-A-Normal-Robot
Copy link
Member

merge when @MrZ626

@Not-A-Normal-Robot
Copy link
Member

been almost a year... will this ever get merged

@MrZ626
Copy link
Collaborator

MrZ626 commented Oct 17, 2022

🤔it just change the effect to old one, but I think new one is better
Maybe someone want change it himself so I keep the code here

@flaribbit
Copy link
Member Author

🤔it just change the effect to old one, but I think new one is better Maybe someone want change it himself so I keep the code here

maybe a setting item should be added for players to choose

@ParticleG
Copy link
Member

I think polygon attacks are COOL

@ParticleG ParticleG force-pushed the main branch 2 times, most recently from 68d0b76 to ed11faf Compare June 15, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Not-A-Normal-Robot Not-A-Normal-Robot Not-A-Normal-Robot approved these changes

Assignees
No one assigned
Labels
hang on Don't resolve/close this for now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaribbit @Not-A-Normal-Robot @MrZ626 @ParticleG