fix custom games #1139
Merged
fix custom games #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can `play custom_` without going through the `customGame` scene
ImpleLee
added a commit
that referenced
this pull request
Oct 17, 2024
Steps to reproduce: 1. reset everything in custom game 2. restart the game 3. go to the custom game scene 4. go to the custom sequence scene and set a new sequence 5. leave the scene and go to the custom game scene 6. begin to clear Unintended behavior: The sequence is still the default old sequence (7-bag) Intended behavior: The sequence is the newly set sequence Rationale: The bug was introduced by #1139. It deleted a line of `apply_locals()` which I wrongly believed that the custom modes will execute initialize() anyway, but it turned out initialization is only executed during the start of the whole game. The patch is simple: just add back the deleted line
Merged
MrZ626
pushed a commit
that referenced
this pull request
Oct 17, 2024
Steps to reproduce: 1. reset everything in custom game 2. restart the game 3. go to the custom game scene 4. go to the custom sequence scene and set a new sequence 5. leave the scene and go to the custom game scene 6. begin to clear Unintended behavior: The sequence is still the default old sequence (7-bag) Intended behavior: The sequence is the newly set sequence Rationale: The bug was introduced by #1139. It deleted a line of `apply_locals()` which I wrongly believed that the custom modes will execute initialize() anyway, but it turned out initialization is only executed during the start of the whole game. The patch is simple: just add back the deleted line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can
play custom_*without going through thecustomGamescene.