Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of some of my English suggestions #1104

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

KonSola5
Copy link
Contributor

Suggestions implemented:

plus some extras:

  • B.G. → BG (that's not an acronym, that stands for Background)
  • line → lines (in CC error),
  • Row → Lines
  • Block → Pieces
  • Normal Lock Reset → Reset Lock Delay on move

And also edited the 40L Sprint WR splash.

@KonSola5
Copy link
Contributor Author

Regarding the torikan text:
"Ended" sounds very unnatural if it comes for ending something.

My proposal would need to change font sizes and add an additional text:

The End

For now...

(Since torikan stands for "max out for the time being").

@shoucandanghehe shoucandanghehe added the localization Localization/Translation Related label Mar 25, 2024
@MrZ626
Copy link
Collaborator

MrZ626 commented Apr 23, 2024

Have you check every "block"? I can still see some remain

@KonSola5
Copy link
Contributor Author

KonSola5 commented Apr 24, 2024

I've now changed every single instance of "block" to "piece" when "block" refers to the piece, and not the locked mino on the field.

Also, I changed:

  • Torikan text: "Ended" -> "The End" (probably requires a font size change)
  • "Draw Blocks" -> "Draw Active Piece" (because that's what this toggle does)
  • "Line No." -> "Line Numbers" - If "rotation centers" do fit, then "line numbers" doesn't need to be shortened.

@MrZ626 MrZ626 merged commit c2bf291 into 26F-Studio:main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Localization/Translation Related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants