-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version bump and tag #82
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@solababs upon secondary review this seems to be missing CLI arguments
src/ctl/plugins/version_base.py
Outdated
@@ -117,6 +123,11 @@ def add_arguments(cls, parser, plugin_config, confu_cli_args): | |||
choices=["major", "minor", "patch", "prerelease"], | |||
help="bumps the specified version segment by 1", | |||
) | |||
op_bump_parser.add_argument( | |||
"--do_not_tag", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@solababs nitpick - should be --do-not-tag
or even better --no-tag
Also needs to be updated in docs: https://github.com/20c/ctl/blob/main/docs/plugins/version.md
Description
Update version bump and tag
Version bump should be able to take arguments to: