chore(eslint): many eslint fixes #1220
Open
+78
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
locked-chest
commented
Feb 7, 2025
locked-chest
commented
- Stronger types for LoginThread and FriendThread
- Error logging for failure to update compiler / check for update
- Enhanced error logging for failure to compile runescript files (maybe?)
- Many more minor things that should not affect actual runtime code
- Stronger types for LoginThread and FriendThread - Error logging for failure to update compiler / check for update - Many more minor things that should not affect actual runtime code
Jameskmonger
reviewed
Feb 7, 2025
| import InternalClient from '#/server/InternalClient.js'; | ||
|
|
||
| import Environment from '#/util/Environment.js'; | ||
|
|
||
| export default class LoginClient extends InternalClient { | ||
| export class LoginClient extends InternalClient { |
|
I had to merge some other priority ones first, let me know if you need me to resolve these conflicts or if you can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.