Add some more checks

1up-lab · Sep 4, 2023 · daa9022 · daa9022
1 parent d991697
commit daa9022
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/assets/SortableListView.ts b/assets/SortableListView.ts
@@ -43,7 +43,7 @@ export class SortableListView {
 
                 formData.append('REQUEST_TOKEN', window.sortableListViews.token)
                 formData.append('action', action ?? '')
-                formData.append('id', id ?? '')
+                formData.append('id', id ?? 0)
                 formData.append('oldIndex', event.oldIndex)
                 formData.append('newIndex', event.newIndex)
 

diff --git a/public/backend.min.js b/public/backend.min.js
diff --git a/public/backend.min.js.map b/public/backend.min.js.map
diff --git a/src/Service/Sorter.php b/src/Service/Sorter.php
@@ -17,6 +17,10 @@ public function __construct(
 
     public function sort(string $table, int $id, int $oldIndex, int $newIndex): void
     {
+        if (0 === $id) {
+            return;
+        }
+
         /**
          * < 0 --> move downward
          * = 0 --> do nothing