Fix spelling of "defaultVisiblity" => "defaultVisibility" #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I consider this as a bug - probably didn't work properly. Only if you misspelled it as well in your config. What do you think? |
|
In my eyes it is a bug fix and a BC Break. I guess People find out quickly after upgrading.Composer will clear cache and give a warning/error about wrong config.I think this can be part of a minor update, but with a good visible info, about this change.Am 11.03.2024 um 10:30 schrieb David Greminger ***@***.***>:
I consider this as a bug - probably didn't work properly. Only if you misspelled it as well in your config. What do you think?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: ***@***.***>
|
bytehead
changed the title
|
I call it clearly a bug and it will be fixed in a bugfix release 👍 |
bytehead
approved these changes
Mar 14, 2024
bytehead
changed the title
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#255
I just come across this, as my IDE did notice.
Needs a closer look.