-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lilygo-t3-s3 #2160
base: development
Are you sure you want to change the base?
Support lilygo-t3-s3 #2160
Conversation
@@ -176,7 +178,7 @@ monitor_speed = 115200 | |||
|
|||
[com] | |||
esp8266_platform = [email protected] | |||
esp32_platform = espressif32@6.1.0 | |||
esp32_platform = espressif32@6.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆 I never realized that we have a version from March 8, 2023, for Espressif32... maybe there's a reason for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it breaks going from 6.7.0
to 6.8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there's a reason for that
Yes, we need to do an extensive testing of the BLE controller before going further. I would suggest to differentiate the PR between the platform evolution and the new board.
Does 6.7.0 supports your board ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use 6.10.0 in my builds. BT seems working (no need for a patched library).
Where is the appropriate place to share and discuss the topic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there's a reason for that
Yes, we need to do an extensive testing of the BLE controller before going further. I would suggest to differentiate the PR between the platform evolution and the new board. Does 6.7.0 supports your board ?
It was added in 6.10.0 unfortunately. I'm fine with leaving this in draft until the platform version is bumped
Description:
Adds support for the
lilygo-t3-s3
with a SX1276: https://lilygo.cc/products/t3s3-v1-0?variant=42740446298293. Tested with the 915MHz board with the FSK encoding version, and a WH51 moisture sensor. This also includes a bump to[email protected]
to get the board defintionChecklist: