[RF] ZgatewatPilight: toggle RawEnabled only if Pilight is active #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind updating the documentation as part of this PR ? |
peshovec
force-pushed
the
pilight-rawenabled
branch
from
92b36e0 to
4039f04
Compare
|
Ok, pushed.
…On Tue, Feb 11, 2025, 15:19 Florian ***@***.***> wrote:
Do you mind updating the documentation as part of this PR ?
It will make it easier to track the changes
—
Reply to this email directly, view it on GitHub
<#2159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHTE3LNYA3VO2CK7WSM5I32PH2HXAVCNFSM6AAAAABWVKYBJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJQHAYTCMRUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When enabling or disabling RawEnabled for Pilight gateway the PilightGateway is deactivated and activated.
The proposed change the rawenabled, only if current active receiver is Pilight. Trying to avoid situation such as: Active receiver is RTL , toggling RawEnabled will finally enable Pilight receiver and potentially there will be "race" between two active receivers, or potentially not "synchronized" changes to the radio module (RTL using RadioLib, Pilight using ELECHOUSE).
If accepted, the documentation regarding Pilight gateway, particular using rawenabled should clarify, that toggling is possible only if Pilight is the active receiver. And that if Pilight is not the active receiver, the mqtt error message when trying to toggle is normal.
Checklist: