[SC-885] OraclePrices library #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # contracts/oracles/UniswapV3LikeOracle.sol # test/CurveOracle.js
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 78.31% 77.83% -0.49%
==========================================
Files 26 26
Lines 738 731 -7
Branches 167 156 -11
==========================================
- Hits 578 569 -9
- Misses 160 162 +2
☔ View full report in Codecov by Sentry. |
ZumZoom
reviewed
Aug 10, 2023
ZumZoom
reviewed
Aug 10, 2023
contracts/libraries/OraclePrices.sol
Outdated
Comment on lines
50
to
56
| OraclePrice[] memory oraclePrices; | ||
| assembly ("memory-safe") { // solhint-disable-line no-inline-assembly | ||
| oraclePrices := mload(0x40) | ||
| mstore(0x40, add(oraclePrices, add(0x20, mul(maxArrLength, 0x40)))) | ||
| mstore(oraclePrices, maxArrLength) | ||
| } | ||
| data = Data(0, 0, oraclePrices); |
There was a problem hiding this comment.
Suggested change
| OraclePrice[] memory oraclePrices; | |
| assembly ("memory-safe") { // solhint-disable-line no-inline-assembly | |
| oraclePrices := mload(0x40) | |
| mstore(0x40, add(oraclePrices, add(0x20, mul(maxArrLength, 0x40)))) | |
| mstore(oraclePrices, maxArrLength) | |
| } | |
| data = Data(0, 0, oraclePrices); | |
| assembly ("memory-safe") { // solhint-disable-line no-inline-assembly | |
| data := mload(0x40) | |
| mstore(0x40, add(data, add(0x80, mul(maxArrLength, 0x40)))) | |
| mstore(add(data, 0x00), 0) | |
| mstore(add(data, 0x20), 0) | |
| mstore(add(data, 0x40), add(data, 0x60)) | |
| mstore(add(data, 0x60), maxArrLength) | |
| } |
ZumZoom
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand thresholdFilter logic to separate library and add it to Oracles