first pass at syndicate integration #549
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR is being deployed to Railway 🚅 |
apps/delta/ponder.config.ts
Outdated
| @@ -1,6 +1,6 @@ | |||
| import { createConfig } from '@ponder/core' | |||
| import { addresses, idRegistryABI, postGatewayABI } from 'scrypt' | |||
| import { http } from 'viem' | |||
| import { Hex, http } from 'viem' | |||
There was a problem hiding this comment.
can we get rid of this added Hex? not seeing any other changes to Delta so should be unncessary? just in terms of keeping the commit trail on delta clean
apps/site/app/api/post/route.ts
Outdated
|
|
||
| const tx = await postGateway.post(post) | ||
| if (!projectId) { |
There was a problem hiding this comment.
lets move as much of this as possible into the syndicate config. did a lil gist brainstorming here https://gist.github.com/0xTranqui/3a00d776f4065db0c77106685f941d24
apps/site/app/api/post/route.ts
Outdated
| }) | ||
|
|
||
| console.log({ successfulTxHash }) |
There was a problem hiding this comment.
we should prob remove most/all of these console logs before merging? what u think
apps/site/lib/api.ts
Outdated
| `https://api.syndicate.io/wallet/project/${projectID}/request/${txID}`, | ||
| { | ||
| method: 'GET', | ||
| headers: { Authorization: `Bearer ${process.env.SYNDICATE_API_KEY}` }, |
There was a problem hiding this comment.
better dx to accept api key as a prop? instead of loading in from env here? like we do for w3supload down below?
apps/site/lib/api.ts
Outdated
| let transactionHash = null | ||
|
|
||
| while (!transactionHash) { | ||
| await new Promise((resolve) => setTimeout(resolve, every)) |
There was a problem hiding this comment.
I feel like the delay is better suited for coming at the end of the loop, and only if its necssary (ie there will be another loop cuz was uncessful) like we do in this similar function that we use to wait for appearnace in ponder db? https://github.com/1ifeworld/river/blob/main/apps/site/lib/getTxnInclusion.ts
There was a problem hiding this comment.
think this is close, but overall would be better suited if we make a beefier syndicate config that exports all of the function definitions in one const. idea for it here https://gist.github.com/0xTranqui/7e9f19aee739395215984f138207c9ee
its like were making our own custom "viem config extension -- esque" syndicate client, tailored specifically for the actions we want to make in river. and then super easy to drop in wherever we need it to be
apps/site/config/syndicateClient.ts
Outdated
| ) | ||
| } | ||
|
|
||
| export const postBatchObject = (postsArray: PostBatchFunction) => ({ |
There was a problem hiding this comment.
I think this function should be called "generatePostBatchTxnInput" or something like that. and read more like a function. same thing with the "postObject" export below
apps/site/app/api/post/route.ts
Outdated
| import type { NextRequest } from 'next/server' | ||
| import { addresses, postGatewayABI } from 'scrypt' | ||
| import type { Hex } from 'viem' | ||
| import { syndicate, postObject, projectId } from '@/config/syndicateClient' |
There was a problem hiding this comment.
will also leave this comment in the gneral review, but we should make this all be accessible just via one "syndicateClient" import.
peep here for gist idea of what this could look like: https://gist.github.com/0xTranqui/7e9f19aee739395215984f138207c9ee
apps/site/app/api/post/route.ts
Outdated
|
|
||
| const tx = await postGateway.post(post) | ||
| const postTxRequest = postObject(post) |
There was a problem hiding this comment.
if postTxnRquest is only used once, can we avoid this const and just put the postObject in the sendTransaction inputs?
apps/site/app/api/postBatch/route.ts
Outdated
| postGatewayABI, | ||
| signer as unknown as ethers.Signer, | ||
| ) | ||
| if (!authToken || typeof authToken !== 'string') { |
There was a problem hiding this comment.
whats the reason we have auth token in here? was it in our earlier routes? is there a reson its in postBatch but not post?
needs testing