Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean property added for automatic close on enter key #26

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ashleydavis
Copy link
Contributor

I've added a property that allows the fuzzy picker to be automatically closed when the user presses the enter key. This is disabled by default for backward compatibility.

@1egoman
Copy link
Owner

1egoman commented Jul 29, 2019

@ashleydavis Can you add any relevant tests for this behavior? (both the pickExactItem prop and the displayCount property being 0 seem like good candidates if I'm understanding your code correctly, if you think of any others too then that's also welcome!)

Otherwise this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants