remove unused generics/phantomdata in generated code #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into #92 when generating some definitions. Only implemented for named field structs (is PhantomData used elsewhere?). I'm not familiar with Kotlin/Scala so wasn't sure what the generated code should look like for the tests (Swift/TS pass).
Rust:
struct UnusedGenericsEmptyStruct<A, B, C> {}Kotlin generates:
object UnusedGenericsEmptyStructinstead ofdata class UnusedGenericsEmptyStruct()Scala generates:
class UnusedGenericsEmptyStruct extends Serializableinstead ofcase class UnusedGenericsEmptyStruct()Are these right? (Tests don't pass for Kotlin/Scala right now due to above)
Can update tests to what the expected gen should be and fix any issues.