Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MSRV and fix UNIX variable skipping #29

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Update MSRV and fix UNIX variable skipping #29

merged 4 commits into from
Aug 25, 2024

Conversation

complexspaces
Copy link
Collaborator

@complexspaces complexspaces commented Aug 25, 2024 •
edited
Loading

This PR handles two three things:

  • Updates our MSRV to 1.56, which is coming up on 3 years old as of this PR.
  • Fixing CI because macos-latest now runs on ARM64 instead of x86.
  • Applies a small fix to the environment variable reading on UNIX platforms so variables without contents are skipped and don't hinder reading from ones that may.

Closes #28

@complexspaces complexspaces force-pushed the updates-and-unix-fix branch 2 times, most recently from dcbedab to ff0a982 Compare August 25, 2024 20:08
@complexspaces complexspaces merged commit 1297689 into main Aug 25, 2024
42 checks passed
@complexspaces complexspaces mentioned this pull request Aug 25, 2024
Closed
@complexspaces complexspaces deleted the updates-and-unix-fix branch September 21, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error detecting locale with an empty LC_ALL
1 participant
@complexspaces