Skip to content

Update PR template with demo section #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndyTitu
Copy link
Contributor

@AndyTitu AndyTitu commented Mar 20, 2024

Overview

This PR adds a new section to the PR template: the functional testing demo section. This is supposed to contain a screenshot style video showing how the newly added shell plugins are supposed to work, and helps provide context to the reviewer as well as to functionally test the changes.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

@@ -3,6 +3,10 @@
Provide a high-level description of this change.
-->

## Functional Demo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this doesn't significantly increase the effort of contributors to add new plugins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants