-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Mappings, Building the Provider and SDKs #3
Adding Mappings, Building the Provider and SDKs #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: I've noticed that there are five empty Pulumi.yaml
files (this one plus one for each of the four sub-directories in the sdk/
folder). I've committed them since they're part of the automated code generation, but just wanted to flag it here in case they're not actually needed.
@@ -143,7 +136,7 @@ func Provider() tfbridge.ProviderInfo { | |||
}, | |||
Golang: &tfbridge.GolangInfo{ | |||
ImportBasePath: path.Join( | |||
fmt.Sprintf("github.com/pulumi/pulumi-%[1]s/sdk/", mainPkg), | |||
fmt.Sprintf("github.com/1Password/pulumi-%[1]s/sdk/", mainPkg), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: Updating this instance of the GitHub organization was missed in an earlier PR; fixing it here (and in the related schema.json
file) to ensure that the Go module paths in sdk/go/onepassword/
resolve correctly.
Update (2024-03-11): This |
@dustin-ruetz I created #4 to resolve the dependency issue. I created that PR on top of your working branch. Now I don't understand why it lists that there are merge conflicts. |
@ringods This PR was very helpful, thanks for putting that up. I'm not sure how/why that caused a merge conflict (especially since you built it from my working branch), but reviewing the file diffs and ensuring that all of my dependencies are up-to-date has helped me work through the errors. I pushed up some new commits and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!👍
This PR implements the work described in the Adding Mappings, Building the Provider and SDKs section of the repo's README.md file.