Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mappings, Building the Provider and SDKs #3

Merged
merged 9 commits into from
Mar 12, 2024

Conversation

dustin-ruetz
Copy link
Contributor

This PR implements the work described in the Adding Mappings, Building the Provider and SDKs section of the repo's README.md file.

@dustin-ruetz dustin-ruetz self-assigned this Mar 9, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: I've noticed that there are five empty Pulumi.yaml files (this one plus one for each of the four sub-directories in the sdk/ folder). I've committed them since they're part of the automated code generation, but just wanted to flag it here in case they're not actually needed.

@@ -143,7 +136,7 @@ func Provider() tfbridge.ProviderInfo {
},
Golang: &tfbridge.GolangInfo{
ImportBasePath: path.Join(
fmt.Sprintf("github.com/pulumi/pulumi-%[1]s/sdk/", mainPkg),
fmt.Sprintf("github.com/1Password/pulumi-%[1]s/sdk/", mainPkg),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: Updating this instance of the GitHub organization was missed in an earlier PR; fixing it here (and in the related schema.json file) to ensure that the Go module paths in sdk/go/onepassword/ resolve correctly.

@dustin-ruetz
Copy link
Contributor Author

dustin-ruetz commented Mar 9, 2024

Note for reviewers: I'm having problems getting the linting to pass (both locally as seen in the screenshot below and in the GitHub Actions lint job). Any ideas as to what might be causing this problem? The errors seem to be coming from dependencies as opposed to this 1Password/pulumi-onepassword repo code itself 🤔

Output of make lint_provider command:

Screenshot: image

Update (2024-03-11): This lint issue is now fixed, see below comment for more detail.

@ringods
Copy link

ringods commented Mar 11, 2024

@dustin-ruetz I created #4 to resolve the dependency issue. I created that PR on top of your working branch. Now I don't understand why it lists that there are merge conflicts.

@dustin-ruetz
Copy link
Contributor Author

@dustin-ruetz I created #4 to resolve the dependency issue. I created that PR on top of your working branch. Now I don't understand why it lists that there are merge conflicts.

@ringods This PR was very helpful, thanks for putting that up. I'm not sure how/why that caused a merge conflict (especially since you built it from my working branch), but reviewing the file diffs and ensuring that all of my dependencies are up-to-date has helped me work through the errors. I pushed up some new commits and the lint job is now passing.

Copy link
Contributor

@volodymyrZotov volodymyrZotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!👍

@dustin-ruetz dustin-ruetz merged commit 3064ba7 into main Mar 12, 2024
1 check passed
@dustin-ruetz dustin-ruetz deleted the ruetz-add-mappings-build-provider-and-sdks branch March 12, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants