Temporarily exclude two files in the Git diff check in the CI/CD release workflow #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulumi codegen bug
dustin-ruetz
changed the title
volodymyrZotov
approved these changes
May 13, 2024
ingridcrant
approved these changes
May 13, 2024
edif2008
approved these changes
May 14, 2024
There was a problem hiding this comment.
Code review
This just comments out a step, which highlights that we skip it for now until the mentioned bug is fixed.
Other notes
I've also double-checked the diff on this branch after running make build_sdks and the following files are modified:
provider/cmd/pulumi-resource-onepassword/schema.jsonsdk/nodejs/getItem.ts
Both of these diffs are caused by the bug mentioned in this PR.
edif2008
reviewed
May 14, 2024
Co-authored-by: Eduard Filip <[email protected]>
…to known Pulumi codegen bug
dustin-ruetz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip checking that the Git worktree is clean for now during the
release.ymlGitHub Actions workflow since themake tfgenandmake build_sdkscommands produce small Git diffs due to a bug in the Pulumi code generation process where the custom package name is not being used in the generated code.Note that while it's definitely a code smell to have a Git diff in the the CI/CD pipeline, the intention of this PR's changes is to work around the Pulumi codegen bug by skipping the "Check worktree clean" step (i.e. just ignoring the fact that there's a Git diff produced in the job for now).