Skip to content

Commit

Permalink
Merge pull request #34 from 1Password/add-prf-extension-input-output-…
Browse files Browse the repository at this point in the history
…types

Add prf extension input output types (PRF#2)
  • Loading branch information
Progdrasil authored Jul 25, 2024
2 parents 9576585 + 4220b59 commit dd56443
Show file tree
Hide file tree
Showing 12 changed files with 691 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
with:
profile: minimal
toolchain: ${{ matrix.rust }}
- run: rustup run ${{ matrix.rust }} cargo test --all-features
- run: rustup run ${{ matrix.rust }} cargo test

typeshare:
name: Typeshare
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ handles client data and its hash.
- The `Client` now returns `CredProps::rk` depending on the authenticator's capabilities. ([#29](https://github.com/1Password/passkey-rs/pull/29))
- ⚠ BREAKING: Rename webauthn extension outputs to be consistent with inputs. ([#33](https://github.com/1Password/passkey-rs/pull/33))
- ⚠ BREAKING: Create new extension inputs for the CTAP authenticator inputs. ([#33](https://github.com/1Password/passkey-rs/pull/33))
- ⚠ BREAKING: Add unsigned extension outputs for the CTAP authenticator outputs. ([#34](https://github.com/1Password/passkey-rs/pull/33))

## Passkey v0.2.0
### passkey-types v0.2.0
Expand Down
1 change: 1 addition & 0 deletions passkey-authenticator/src/authenticator/get_assertion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ where
name: "".into(),
}),
number_of_credentials: None,
unsigned_extension_outputs: None,
})
}
}
Expand Down
1 change: 1 addition & 0 deletions passkey-authenticator/src/authenticator/make_credential.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ where
auth_data,
fmt: "None".into(),
att_stmt: vec![0xa0].into(), // CBOR exquivalent to empty map
unsigned_extension_outputs: None,
};

// 10
Expand Down
4 changes: 2 additions & 2 deletions passkey-client/src/extensions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ where
&self,
request: Option<&AuthenticationExtensionsClientInputs>,
) -> Option<make_credential::ExtensionInputs> {
request.map(|_| make_credential::ExtensionInputs {})
request.map(|_| make_credential::ExtensionInputs::default())
}

/// Build the extension outputs for the WebAuthn client in a registration request.
Expand Down Expand Up @@ -73,6 +73,6 @@ where
&self,
request: Option<&AuthenticationExtensionsClientInputs>,
) -> Option<get_assertion::ExtensionInputs> {
request.map(|_| get_assertion::ExtensionInputs {})
request.map(|_| get_assertion::ExtensionInputs::default())
}
}
1 change: 1 addition & 0 deletions passkey-types/src/ctap2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ mod attestation_fmt;
mod error;
mod flags;

pub mod extensions;
pub mod get_assertion;
pub mod get_info;
pub mod make_credential;
Expand Down
Loading

0 comments on commit dd56443

Please sign in to comment.