Move GitHub Issue loading

1Password · Mar 19, 2024 · 4b37c28 · 4b37c28
1 parent 3980c65
commit 4b37c28
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/script/github.go b/script/github.go
@@ -21,6 +21,7 @@ type GitHub struct {
 func (g *GitHub) Init() error {
 	if isTestingIssue() {
 		debugMessage("Skipping GitHub Init")
+		g.Issue = getTestIssue()
 		return nil
 	}
 

diff --git a/script/reviewer.go b/script/reviewer.go
@@ -3,8 +3,6 @@ package main
 import (
 	"fmt"
 	"log"
-
-	"github.com/google/go-github/v60/github"
 )
 
 type Reviewer struct {
@@ -19,15 +17,7 @@ func (r *Reviewer) Review() {
 	}
 
 	// TODO: parse and validate the issue's body contents
-	fmt.Println(r.GetIssue())
-}
-
-func (r *Reviewer) GetIssue() github.Issue {
-	if isTestingIssue() {
-		return getTestIssue()
-	} else {
-		return *r.GitHub.Issue
-	}
+	fmt.Println(r.GitHub.Issue)
 }
 
 func (r *Reviewer) PrintErrorAndExit(err error) {

diff --git a/script/testing.go b/script/testing.go
@@ -25,7 +25,7 @@ func debugMessage(message string, data ...interface{}) {
 	}
 }
 
-func getTestIssue() github.Issue {
+func getTestIssue() *github.Issue {
 	data, err := os.ReadFile(fmt.Sprintf("./script/test-issues/%s.json", testIssueName))
 	if err != nil {
 		log.Fatalf("Unable to read the file: %v", err)
@@ -38,5 +38,5 @@ func getTestIssue() github.Issue {
 		log.Fatalf("Unable to unmarshal JSON: %v", err)
 	}
 
-	return issue
+	return &issue
 }