Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #109

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Bump dependencies #109

merged 4 commits into from
Nov 30, 2023

Conversation

gevalo1
Copy link
Contributor

@gevalo1 gevalo1 commented Nov 17, 2023

This PR updates all dependencies to the latest version.

Most importantly for me it bumps Axios, which fixes https://nvd.nist.gov/vuln/detail/CVE-2023-45857 (reported by Snyk).

@gevalo1
Copy link
Contributor Author

gevalo1 commented Nov 29, 2023

@volodymyrZotov @dustin-ruetz, do either of you potentially have time to review this PR? 🙏

@dustin-ruetz dustin-ruetz self-requested a review November 30, 2023 17:08
Copy link
Contributor

@dustin-ruetz dustin-ruetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for submitting this PR, @gevalo1 - we really appreciate the time you spent making this contribution.

The code changes are straightforward and everything looks good to me. (I left one non-blocking comment as more of a "troubleshooting FYI" for myself/my team to reference why we're using @ts-ignore instead of @ts-expect-error in the test files, but I will go ahead and resolve this comment prior to merging the PR.)

PR approved ✅

__test__/adapter.test.ts Show resolved Hide resolved
@dustin-ruetz dustin-ruetz merged commit 162f70a into 1Password:main Nov 30, 2023
1 check passed
@dustin-ruetz
Copy link
Contributor

@gevalo1 This PR is included in the v1.4.1 release. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants