Fix tests

1Hive · Aug 31, 2023 · 127095f · 127095f
1 parent 5a37f6e
commit 127095f
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 123 deletions.
diff --git a/package.json b/package.json
@@ -39,4 +39,4 @@
     "ts-node": "^10.2.1",
     "typescript": "^4.4.2"
   }
-}
+}
diff --git a/packages/hardhat/coverage.json b/packages/hardhat/coverage.json
diff --git a/packages/hardhat/hardhat.config.ts b/packages/hardhat/hardhat.config.ts
@@ -1,5 +1,4 @@
 import { config as dotenvConfig } from "dotenv";
-import "solidity-coverage";
 import "hardhat-deploy";
 import fs from "fs";
 import chalk from "chalk";
@@ -9,6 +8,7 @@ import "@openzeppelin/hardhat-upgrades";
 import "@nomiclabs/hardhat-ethers";
 import "hardhat-typechain";
 import "typechain";
+import "solidity-coverage";
 import { task, HardhatUserConfig, types } from "hardhat/config";
 import { HttpNetworkUserConfig } from "hardhat/types";
 import { resolve } from "path";

diff --git a/packages/hardhat/test/QuestFactory.test.ts b/packages/hardhat/test/QuestFactory.test.ts
@@ -44,32 +44,6 @@ describe("[Contract] QuestFactory", function () {
       .mint(owner.address, fromNumber(1000));
   });
 
-  it("SHOULD transfer ownership WHEN initialOwner is different than deployer", async function () {
-    // Arrange
-    const contractFactory = await ethers.getContractFactory(
-      "QuestFactory",
-      owner
-    );
-    // Act
-    const contract = (await upgrades.deployProxy(
-      contractFactory,
-      [
-        owner.address,
-        createDepositToken.address,
-        depositAmount,
-        playDepositToken.address,
-        depositAmount,
-        stranger.address,
-      ],
-      {
-        initializer: "initialize",
-      }
-    )) as QuestFactory;
-    await contract.deployed();
-    // Assert
-    expect(await contract.owner()).to.equal(stranger.address);
-  });
-
   describe("Methods", () => {
     beforeEach(async function () {
       const contractFactory = await ethers.getContractFactory(
@@ -78,18 +52,19 @@ describe("[Contract] QuestFactory", function () {
       );
       questFactoryContract = (await upgrades.deployProxy(
         contractFactory,
-        [
-          owner.address,
-          createDepositToken.address,
-          depositAmount,
-          playDepositToken.address,
-          depositAmount,
-          owner.address,
-        ],
+        [owner.address],
         {
           initializer: "initialize",
         }
       )) as QuestFactory;
+      questFactoryContract.setCreateDeposit(
+        createDepositToken.address,
+        depositAmount
+      );
+      questFactoryContract.setPlayDeposit(
+        playDepositToken.address,
+        depositAmount
+      );
       await questFactoryContract.deployed();
     });