399 pool form touchup #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor the CommunityCard component to include TooltipIfOverflow for efficient tooltip display of the name. - Added a tooltip for better overflow handling on the "Switch to" button in the Connect Wallet component. - Added a tooltip to display the title in the FormPreview component to handle text overflow. - Added a tooltip for overflow text on the proposal title in the ProposalCard component and removed an unused prop. - Added a tooltip component to handle overflow text in the proposals component. - Added a new TooltipIfOverflow component to display tooltips for overflowing text.
- Enhanced the styling of the address input by adding text size and font properties. - Updated the styling of the input field to include a monospace font and smaller text size. - Added a new font family option for monospaced text in the Tailwind configuration.
- Added an optional inline display prop to the FormRadioButton component to allow flexible layout options. - Refactor the voting weight system selection in the form to use radio buttons with descriptions instead of a select dropdown and integrate the corresponding input conditionally.
- Updated ESLint configuration to allow avoiding escape for quotes in TypeScript. - Refactor form input components to utilize a suffix prop instead of span elements for symbol and percentage display. - Refactor the implementation of the address input handling to use a more streamlined input variable instead of a reference. - Enhanced the FormCheckBox component by adding optional tooltip support, error handling, and value management. - Remove the unused children prop and add a suffix prop to enhance the FormInput component. - Refactor the FormSelect component to make the errors prop optional and change the fragment to a div for improved structure. - Refactor the PoolEditForm component by replacing span suffix elements with a new suffix prop in the FormInput component for cleaner code. - Enhance the PoolForm component by adding ruling time functionality and streamlining user input fields for proposal and dispute collateral. - Introduced a utility for parsing time units and conversions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Gemini Code Review encountered an error. Here is the step log: |
- Refactor the FormAddressInput component to simplify state management and streamline avatar URL assignment logic. - Removed a default value for the `defaultChecked` property in the FormCheckBox component. - The changes primarily focus on enhancing the PoolEditForm component by refining input handling, adding new fields for ruling time and tribunal options, and improving the overall structure for better user experience. - Refactor the time parsing logic in the PoolForm component to convert days into a more readable format while ensuring the display adapts for singular and plural units. - Added a new property for default ruling timeout to the component's props and utilized it within the component logic.
- Refactor the calculation of default ruling timeout and adjust field properties for improved precision in the pool edit form. - Updated the number input configuration in the PoolForm component to simplify the step value for better user input.
- Updated the input component to allow for more precise step values in the PoolForm.
# Conflicts: # apps/web/components/Forms/PoolEditForm.tsx # apps/web/components/PoolHeader.tsx # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #399
This pull request involves several updates to the forms and components in the
apps/webdirectory, focusing on improving user experience and code maintainability. The key changes include the addition of a tooltip component, updates to form input handling, and various UI improvements.Tooltip Component Integration:
apps/web/components/CommunityCard.tsx: IntegratedTooltipIfOverflowto handle overflow text in the community card title. [1] [2]apps/web/components/ConnectWalletButton.tsx: AddedTooltipIfOverflowto the network switch button. [1] [2]apps/web/components/Forms/FormPreview.tsx: UsedTooltipIfOverflowfor the form preview title. [1] [2]Form Input Enhancements:
apps/web/components/Forms/FormInput.tsx: Added asuffixprop to handle suffix text within inputs. [1] [2] [3]apps/web/components/Forms/CommunityForm.tsx: Updated form inputs to use the newsuffixprop for token symbols and percentages. [1] [2]apps/web/components/Forms/PoolEditForm.tsx: Applied thesuffixprop for percentage and day inputs. [1] [2] [3]Form Component Updates:
apps/web/components/Forms/FormCheckBox.tsx: Enhanced the checkbox component with optional tooltip and value handling. [1] [2]apps/web/components/Forms/FormRadioButton.tsx: Added aninlineprop to allow radio buttons to be displayed inline. [1] [2]apps/web/components/Forms/FormSelect.tsx: Minor adjustments to the select component layout. [1] [2] [3]Additional Changes:
apps/web/.eslintrc.js: Updated ESLint configuration to allow escaping in quotes.apps/web/components/Forms/PoolForm.tsx: Added handling forrulingTimewith default value parsing and conversion. [1] [2] [3] [4] [5] [6]These changes enhance the user interface and improve the maintainability of the codebase by introducing reusable components and updating form handling logic.