Implement prechat timer pop up #52
Conversation
|
|
||
| if (popUpHtml) { | ||
| this.elements.chatbotContainer.appendChild(popUpHtml); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
@tuseto
Can't you just use the delay function and omit the setTimeout?
There was a problem hiding this comment.
I can, but I don't want to. I even want to remove the delay function.
src/lib/helpers.js
Outdated
| @@ -126,6 +126,11 @@ export const extractStringWithBrackets = (message) => { | |||
| }; | |||
| }; | |||
|
|
|||
| export function removeTextBetweenHashtags(input) { | |||
There was a problem hiding this comment.
@tuseto
There is a function called "clearButtonCodes" in the action-service.js that does the same, maybe we can use move it here in the helpers.js and remove "removeTextBetweenHashtags".
There was a problem hiding this comment.
I moved the function into action-service, but cannot use the old one, they both are doing different things.
There was a problem hiding this comment.
I was suppose to be the other way around, use the already existing function in the from the action service called (clearButtonCodes) and move it into helpers.js and then remove the function you wrote.
There was a problem hiding this comment.
We can't clear all codes before the message is loaded (when all codes are cleared). It will result in more changes.
No description provided.