Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with adjustClonedNode and onclone options #186

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

juliendorra
Copy link

This two key options were missing from the list of options.

I had to hunt down infos about them in different places, I think it's helpful to have them explained with other options.

This two key options were missing from the list of options.
@IDisposable
Copy link
Member

Awesome! Thanks tons... one request... for the onClone doc section, could you point at a jsFiddle that shows how to use it?

This trivial example would be good sample

@juliendorra
Copy link
Author

Hi,

I feel like the jsFiddle should be added in the Usage section, not the list of options, like for the adjustClonedNode option where there is a specific usage example.

So my suggestion is: let's merge it like that, it's a small addition, and another pull request could be written for the Usage section, with maybe a re-organisation of the Readme

@IDisposable IDisposable merged commit c2fe975 into 1904labs:main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants