Prevent overriding styles on clone node if already style exists #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if already a clone node has such styles since we believe these styles are overriden through `adjustCloneNode` option so overriding again to the value from source or parent just reseting the styles overriden through`adjustCloneNode` option
|
Thanks for merging ! |
|
Won't be able to get a release out until the weekend, sorry |
|
@IDisposable kindly publish a release if possible, we are depending on this change. |
|
Released in 3.3.1, thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily solves #170
Also seems it essential to not override (or reset) styles which are already got override through
adjustCloneNodefromoptions. so this PR prevents that reset if clone node has a style property already.@IDisposable