-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 431 to Production #11507
Merged
Merged
Deploy RC 431 to Production #11507
+1,841
−1,528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Upcoming Features, Partner Email Selection, Reset selected email session value on email deletion
changelog: User-Facing Improvements, Localization, Improve Spanish translation for reCAPTCHA disclosure
* Log A/B test buckets for Face/Touch recommend visited changelog: Internal, A/B Tests, Log A/B test buckets for Face/Touch recommend visited * Include submitted
) * Fix aria-disabled button override styling for active buttons * Update JSDOM to latest version For ARIA reflection: jsdom/jsdom#3655 * SpinnerButton: Disable on submission via aria-disabled changelog: Bug Fixes, Accessibility, Avoid focus loss on submit button when submitting form * SubmitButton: Disable on submission via aria-disabled * Deduplicate yarn.lock * Implement WebAuthn verification by binding submit event Rely on SubmitButtonElement to control whether submit event is emitted based on whether it's already being submitted
changelog: User-Facing Improvements, In-Person Proofing, Update the translations for the IPP option on the doc auth error page.
…11497) changelog: Internal, Maintenance, Update identity-hostdata and redis-session-store to support Rails 8
* rebased from main * update the doc for the analytics call changelog: Upcoming Features, Document Authentication, Socure webhook event attribute updates * move empty event webhook test
changelog: Internal, Documentation, Update port forwarding instructions for Android Co-authored-by: Andrew Duthie <[email protected]>
* Fix HTML escaping for partner email sharing changelog: Upcoming Features, Partner Email Selection, Fix HTML escaping for partner email sharing * Add linter for html-safe translation calls * Reword spec description for showing user emails Co-authored-by: Zach Margolis <[email protected]> * Lint controllers for HTML t view helper violations Related: #11491 (comment) --------- Co-authored-by: Zach Margolis <[email protected]>
* Replace Webpack dev server with zero-dependency alternative changelog: Internal, Dependencies, Replace Webpack dev server with zero-dependency alternative * Update example to conditionally include plugin for development * End server on compilation close * Remove unnecessary build promise initialization #11485 (comment) * Avoid setting specific encoding for file read stream Let response deal with it as needed
* Exclude telephony strings from font glyph scraper changelog: Internal, Automated Tooling, Exclude telephony strings from font glyph scraper * Exclude user_mailer strings from font glyph scraper * Use Hash#each_key to iterate hash keys
* Add identifier for explicit frontend error logging changelog: Internal, Analytics, Add identifier for explicit frontend error logging * Update frontend production errors debugging * Update FrontendLogController expected NewRelic call
* changelog: Upcoming Features, socure, remove customerUserID from document request to socure * Fixing rebase * removing customerUserID from socure test responses to more accuratly represent acutal socure response
* feat: add tests for new heading in InPersonLocations component * feat: add resultsSectionHeadingComponent prop to InPersonLocation and FullAddressSearch * feat: add tests for FullAddressSearch new ResultsSectionHeading * changelog: User-Facing Improvements, In-person proofing, add optional results section heading pro for FullAddressSearch component * Update app/javascript/packages/address-search/components/full-address-search.spec.tsx Co-authored-by: Andrew Duthie <[email protected]> * changelog: User-Facing Improvements, In-person proofing, add optional results section heading pro for FullAddressSearch component * feat: remove waitFor in the full-address-search test * feat: updated changelog * feat: add expect to assertion --------- Co-authored-by: Andrew Duthie <[email protected]>
…ps locations controller (#11470) * Adding error handling and tests to public usps locations controller changelog: Internal, In-person Proofing, Adding graceful error handling and analytics in public usps locations controller
changelog: Internal, Maintenance, Remove review-app image build
* LG-14464: Show warning CTA on TMX API exception **Why** * The "internal error" view displayed during IdV is a last resort view. Prior to this change, this view was also shown when we received a ThreatMetrix API response that included an exception message. * Showing the internal error view for an unknown exception raised by the ThreatMetrix API is not useful for the subject undergoing proofing and it obfuscates the action that can be taken by either the proofing subject or the support agent investigating the identity resolution errors. **How** * Added a logic branch to the routing handling of `Idv::VerifyInfoConcern#idv_failure` that still preferences the known actionable error cases (i.e., ssn_failure, rate_limiter, etc.), which is eventually called by both `Idv::VerifyInfoController` and `Idv::InPerson::VerifyInfoController` 1. The first new case handles the ThreatMetrix API exception 2. The second new case handles when there is no exception, but the resolution check (e.g., InstantVerify) didn't pass. * Updated the Idv::VerifyInfoController spec to examine the expected routing and the expected shape of the ThreatMetrix API exception response. As the exception message is an arbitrary unstructured String, we do not test for specific values and instead ensure that the *shape* of the response in our analytics meets a minimum conformance in structure and value types. **Notes** * This is a difficult to replicate error as it relies on blackbox behavior exhibited by our vendor APIs. changelog: Internal, IdV resolution, Error routing for vendor API exceptions Link to the relevant ticket: [LG-14464](https://cm-jira.usa.gov/browse/LG-14464)
* Improve race condition handling for slow reCAPTCHA load changelog: Internal, reCAPTCHA, Improve race condition handling for slow reCAPTCHA load * Add comment explainer for constant * Format numeric constant of thousands * Improve interim loader script state handling * Fix grammer "once loads" -> "once loaded"
…11464) * add desktop test mode to determine if upload is disabled * check for socure doc auth vendor * add changelog changelog: Internal, Doc Auth Socure, configure upload_disabled for socure * change some logic with upload_disabled? * add tests to hybrid_handoff feature spec * linty mclinterson * test mode to desktop_selfie_test_mode * lint * Update spec/features/idv/doc_auth/hybrid_handoff_spec.rb Co-authored-by: Amir Reavis-Bey <[email protected]> --------- Co-authored-by: Amir Reavis-Bey <[email protected]>
changelog: Bug Fixes, Data Warehouse, Only export stats for tables with integer id columns
* Avoid setting reCAPTCHA token on failed execute changelog: Internal, Anti-Fraud, Avoid setting reCAPTCHA token on failed execute * Set token TypeScript type If this were set previously, we'd get TypeScript warnings on attempting to assign potentially-undefined value to input field * Remove unnecessary await
…ded (#11498) * changelog: Upcoming Features, socure, reset socure docv url * fixing test and lint * simplfying test, resolving pr comments * adding contexts and tests to existing contexts * resolving pr comments * Redusing test prep before webhook session complete and expired calls
* add nginx image and build * changelog: Internal, Adding nginx image for k8s deployment * Adding changelog changelog: Internal, Adding nginx image for k8s deployment * generate self-signed certs here in the image * add openssl so we can gen certs * making sure CI pipeline doesn't break changelog: Internal, Containerization, Adding nginx image for k8s deployment * add nginx image to review app patch
aduth
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features