add nginx image and build #11480
add nginx image and build #11480
Conversation
timothy-spencer
changed the title
changelog: Internal, Adding nginx image for k8s deployment
changelog: Internal, Containerization, Adding nginx image for k8s deployment
timothy-spencer
changed the title
| - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH | ||
| variables: | ||
| BRANCH_TAGGING_STRING: '--destination ${ECR_REGISTRY}/identity-idp/nginx:main' | ||
| - if: $CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH |
There was a problem hiding this comment.
Can we add a condition to not run the build on a PR if the relevant files haven't changed? It would still build on main right?
There was a problem hiding this comment.
wouldn't that break reviewapps if a given idp image lacks a matching nginx image with the same tag?
There was a problem hiding this comment.
We kinda do want it to get built even if there's no changes to the files, to make sure that we get the latest images and packages. This will help us from having security vulnerabilities if we keep building it regularly.
There was a problem hiding this comment.
Right, it would still get built on any change to main, which would be frequently enough for that?
There was a problem hiding this comment.
the image tag for idp and nginx need to match exactly or the current deploy process will fail, not really a guarantee that the images exist otherwise or to know what the "current" is
There was a problem hiding this comment.
Oh, I see what you mean. Sorry, I thought you were saying only build on changes to the files while on main. I'm pretty sure that we can rig that up.
But it seems like we would want to build an nginx image on PRs too, in case we make changes to the dockerfile or .conf, right?
There was a problem hiding this comment.
Maybe I should ask: is there a reason why we wouldn't want to build an image almost every time?
🛠 Summary of changes
Added nginx image build for kubernetes.
This is to fix https://gitlab.login.gov/lg-team/mary/containerization-initiative/-/issues/85