LG-14700 Remove Unused CSS styling for selfie input #11313
Conversation
[skip changelog]
|
Is there a screenshot of what this is intended to look like? |
Yes, adding it to screenshot section of original comment. This is also how the field looked in the previous branch. Tested locally. |
| @@ -17,7 +17,7 @@ | |||
| border-width: 3px; | |||
| } | |||
|
|
|||
| usa-file-input:not( | |||
| .usa-file-input:not( | |||
There was a problem hiding this comment.
What exactly are these styles meant to do? I'm having trouble figuring out what combination of states this is meant to apply to.
There was a problem hiding this comment.
It is supposed to apply to the acuant input fields that don't have values pending and are selfie inputs (not front/back ID inputs)
There was a problem hiding this comment.
During initial capture and all subsequent selfie input fields during recapture if failed attempts.
There was a problem hiding this comment.
But I don't see how these styles ever apply. I'm not seeing 21rem height on the back/front fields when I test. usa-form-group--success is only applied if the image is changed, but then we exclude usa-file-input--has-value so I don't see how they ever get applied.
Could you show me a screenshot where the field is rendered at 21rem height?
There was a problem hiding this comment.
The image ratio changes (21rem height) should only apply to the selfie capture. Below are some images of the ratio in effect. The ID fields should remain unchanged.
There was a problem hiding this comment.
Pushed up some edits to remove unneeded classes
There was a problem hiding this comment.
I don't think these styles are being applied. The screenshot you showed is not 21rem height.
This is what it would look like if the styles were actually applied. I simulated this by hard-coding a style for 21rem height. It looks different from your screenshot, and also overlaps with the button.
AShukla-GSA
changed the title
|
@AShukla-GSA What's the status of this pull request? Can it be merged? |
I was asked by my team and PM to ticket this for a future sprint and keep the PR (but put a Do Not Merge Label on it). |
|
Any idea when that ticket might be prioritized? I'd hate to risk this falling by the wayside and forgotten about, especially when you've already done the work and the pull request is approved. |
I can bring it up to them in our next stand up, and I will make it a priority to pick it up from the backlog if free. |
[skip changelog]
🎫 Ticket
Link to the relevant ticket:
LG-14700
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
After: