Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rexml to resolve security advisory #10953

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Bump rexml to resolve security advisory #10953

merged 3 commits into from
Jul 17, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 17, 2024

🛠 Summary of changes

Updates rexml to resolve a security advisory.

Name: rexml
Version: 3.3.1
CVE: CVE-2024-39908
Criticality: Unknown
URL: https://github.com/ruby/rexml/security/advisories/GHSA-4xqq-m2hx-25v8
Title: DoS in REXML
Solution: upgrade to '>= 3.3.2'

📜 Testing Plan

  1. Run make audit
  2. Observe no errors in output

changelog: Internal, Dependencies, Update dependencies to resolve security advisories
@aduth
Copy link
Member Author

aduth commented Jul 17, 2024

Based on the failing spec, it looks like this version update changed an expected behavior with how AAMVA requests are generated. It's only the difference of a newline character, but I'm going to take a closer look.

@mitchellhenke
Copy link
Contributor

Wonder if it was ruby/rexml#164?

@aduth
Copy link
Member Author

aduth commented Jul 17, 2024

Based on the failing spec, it looks like this version update changed an expected behavior with how AAMVA requests are generated. It's only the difference of a newline character, but I'm going to take a closer look.

The release notes include a number of changes unrelated to the specific security fix. I think the change here is a result of ruby/rexml#164 . I pushed a sync-up to the fixture file in 0493eb0. I also added rexml as an explicit dependency in Gemfile since we're using it in our code.

@aduth aduth merged commit 87c1d60 into main Jul 17, 2024
2 checks passed
@aduth aduth deleted the aduth-rexml-advisory branch July 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants