Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds foreman to dev bundle group and removes unneeded \ in makefile #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds foreman to dev bundle group and removes unneeded \ in makefile #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ gem 'nokogiri', '~> 1.16'
gem 'rack', '~> 3.0.0'
gem 'rake', '~> 13.0.0'

gem 'foreman', group: :development

group :test do
gem 'capybara'
gem 'capybara-selenium'
Expand Down
2 changes: 2 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ GEM
selenium-webdriver
coderay (1.1.3)
diff-lcs (1.5.1)
foreman (0.87.2)
matrix (0.4.2)
method_source (1.0.0)
mini_mime (1.1.5)
Expand Down Expand Up @@ -93,6 +94,7 @@ PLATFORMS
DEPENDENCIES
capybara
capybara-selenium
foreman
newrelic_rpm
nokogiri (~> 1.16)
prometheus-client
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ run:
foreman start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet we could remove foreman and the Procfile entirely and just inline this?

Suggested change
foreman start
bundle exec puma -p $PORT -S ~/puma -C config/puma.rb


test:
bundle exec rspec spec/
bundle exec rspec spec