Skip to content
This repository has been archived by the owner on Sep 9, 2019. It is now read-only.

Automated deploys #221

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Automated deploys #221

merged 1 commit into from
Sep 21, 2016

Conversation

jmhooper
Copy link
Member

Fixes issue(s) #204

Changes proposed in this pull request:

  • Setup automated deploys with Travis
  • Update documentation on contributing to cover automated deploys

When I go to merge this, I plan to create a new develop branch and merge to that to verify that automated deploys actually work. Once that is verified, I will merge to master.

@jessieay
Copy link
Contributor

This looks great! Sounds like we should set the default GH branch to develop, then?

@jmhooper
Copy link
Member Author

@jessieay: Yeah, probably the right move after this is merged to develop

Deploying from CI failed because the `cf` command was not present on the CI server.

This commit adds Cloud Foundry as a dependency per the example in the [cloud.gov docs](https://docs.cloud.gov/apps/continuous-deployment/)
@jmhooper
Copy link
Member Author

@jessieay: Pushed develop and the deploy failed. I put up another commit that should hopefully fix the problem.

@jessieay
Copy link
Contributor

Do you want to create a develop branch off of master now and open this PR against develop so we can test the new flow?

@jmhooper
Copy link
Member Author

@jessieay I created the develop branch yesterday and took a swing at it. The build failed because the Travis didn't know about Cloud Foundry.

In my latest commit I followed the guide in the cloud.gov docs to add the dependency.

https://github.com/18F/dolores-landingham-slack-bot/tree/develop

I'll change the target branch of this PR to develop.

@jmhooper jmhooper changed the base branch from master to develop September 21, 2016 16:59
@jessieay
Copy link
Contributor

It looks like some of your changes are no longer showing up? did you create develop off of your branch rather than master, perhaps? I'd expect the diff to look the same as it did before, but it's a lot smaller 🐯

@jmhooper
Copy link
Member Author

Well sort of. I merged this branch into develop the other night to test the deploy, so the changes from the old diff are already there. The deploy failed for the reasons above, so I added another commit to fix that problem. The changes from that commit are what is showing in the diff now.

@jessieay
Copy link
Contributor

Ah didn't realize! Ok will merge

@jessieay jessieay merged commit 3ea6a17 into develop Sep 21, 2016
@jessieay jessieay deleted the jmhooper-automated-deploys branch September 21, 2016 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants