Switch from Moment.js to the Temporal API #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/scripts/angry-tock.js
Outdated
| */ | ||
| const m = () => moment.tz(ANGRY_TOCK_TIMEZONE); | ||
| const m = () => |
There was a problem hiding this comment.
Maybe rename this to t or even something verbose like currentZonedDateTime()?
Suggested change
| const m = () => | |
| const currenetZonedDateTime = () => |
There was a problem hiding this comment.
Yes! I put this on my mental checklist of things to come back and do and then forgot. But your comment also reminded me that I'd made this functionality available from the dates utility module, so I switched to using that. 😄
geekygirlsarah
force-pushed
the
main
branch
from
88e589d to
0768aaa
Compare
|
Closing as ancient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longterm WIP
The Temporal API is currently a TC39 stage 3 proposal, which means the API is nearly completed and is not expected to change much more before final approval. It will be a while yet before it has native implementations, but there's no reason we can't start playing with it now using the polyfill.
The goal of this WIP PR is to explore migrating every current use of Moment.js in Charlie to the Temporal API. Some of those may be harder than others, and may justify switching to a different library instead of using the Temporal API directly. Since there's no rush to make this change, a long-running PR seemed like a reasonable approach to figuring out what we should do.
The following parts of the bot rely on Moment.js and should be migrated:
This PR is a step towards addressing #295.