Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gets the site building and major content migrated #3850

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

beechnut
Copy link
Contributor

@beechnut beechnut commented Jun 4, 2024

Pull request summary

Closes #3845 and #3847.

beechnut added 5 commits May 30, 2024 11:10
This commit fixes or works around all the errors that prevent the 11ty site from building at all.

This commit:
- Fixes all date metadata in blog posts, to conform to YAML date formats
- Implements placeholder filters (usually returning the input or a TODO message) so there are no missing filter errors.
- Sets sitewide layout path so we can remove `layouts/` from all the layout metadata.
- Moves some assets around to link them correctly
- Updates filter parameters to have quotes around strings, instead of Jekyll's bare params
- Deletes unpublished joke authors

The site is not building *correctly* or outputting the correct pages/content.
This commit:

- Fixes post permalinks
  - Moves _posts/ to posts/. Let's face it, the underscore isn't doing anything for anyone.
  - Customizes blog posts permalinks via posts/posts.json
  - Adds a toDatePath filter, which supports generating the posts permalinks
- Moves all pages to non-underscored folders within content/
- Updates config and marks some suspected guides-specific config for later assessment/removal
- Gets author pages rendering
- Fixes the robots.txt and Google verification pages
This commit:

- Moves all author data into single CSV file
  - Adds CSV as a data format
  - Incidentally, adds "yml" as a valid YAML file extension
- Removes full_name from all authors where full_name = "{first_name} {last_name}"
- Sets author page title to full name / computed full name
- Sets H1 to full name / computed full name
- Removes alum status - it's so out of date it's wrong and not worth fixing
- Removes author Markdown pages
- Incidentally, moves principles/ into content/pages/ (noticed while moving other files)
This commit:
- Removes "author published" status checks
- Re-implements team_link and team_photo filters
- Re-implements an "authors' matching posts" filter.
- Refactors the author post display
  - Refactors layout into partials
  - Refactors various author / post display logic
  - Removes unnecessary (hopefully) context mutation
- Fixes author data
  - Adds missing team member data
  - Renames authors.csv -> team_members.csv because global data was polluting post.data.authors

The consequence of removing the `published` is that we'll have 63 pages for unpublished authors, most/all of whom are team members featured in the "we asked 100 colleagues" posts.

These pages are unlinked so no one is likely to stumble upon them by accident. Perhaps we can add a robots.txt entry for them later so they're not indexed.

This doesn't have a meaningful impact on performance.
@beechnut beechnut requested a review from a team as a code owner June 4, 2024 14:26
@beechnut beechnut marked this pull request as draft June 4, 2024 15:11
Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- can confirm it builds.

Side note, I cannot do npm run dev -- but npm run assets:build and npm run serve work fine.


> [email protected] dev
> npm run clean && npm-run-all -p dev:assets dev:serve


> [email protected] clean
> rimraf _site

node:internal/modules/cjs/loader:1146
  throw err;
  ^

Error: Cannot find module './'

@beechnut beechnut force-pushed the replatform/get-it-building branch from 5ffb5f3 to b625cf0 Compare June 4, 2024 22:15
There were 176 JavaScript and legacy HTML errors. This commit fixes that.

This commit:

- Fixes eslint errors, ignoring only the resolution of the csv-parse library. From quick research, this is a common problem.
- Fixes HTML validation errors, making tags compliant. (e.g. wraps <figcaption> in <figure>)
- Sets the passthrough mode in 11ty. Adding `assets/` as a passthrough caused "not a directory" errors, and setting this mode fixed those errors.
- Changes some .md files to .html. Several files were HTML but rendering as Markdown, resulting in the Markdown renderer adding tons of extraneous <p> or </p> tags but not closing them.
- Incidentally reorganizes services_projects folder to projects/services/.

HTML is not guaranteed to be fully correct.
@beechnut beechnut force-pushed the replatform/get-it-building branch from b625cf0 to 0e55feb Compare June 4, 2024 22:16
@beechnut beechnut marked this pull request as ready for review June 4, 2024 22:20
@beechnut beechnut merged commit 02d74e4 into replatform-main Jun 4, 2024
3 of 7 checks passed
@beechnut beechnut deleted the replatform/get-it-building branch June 4, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants