-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gets the site building and major content migrated #3850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes or works around all the errors that prevent the 11ty site from building at all. This commit: - Fixes all date metadata in blog posts, to conform to YAML date formats - Implements placeholder filters (usually returning the input or a TODO message) so there are no missing filter errors. - Sets sitewide layout path so we can remove `layouts/` from all the layout metadata. - Moves some assets around to link them correctly - Updates filter parameters to have quotes around strings, instead of Jekyll's bare params - Deletes unpublished joke authors The site is not building *correctly* or outputting the correct pages/content.
This commit: - Fixes post permalinks - Moves _posts/ to posts/. Let's face it, the underscore isn't doing anything for anyone. - Customizes blog posts permalinks via posts/posts.json - Adds a toDatePath filter, which supports generating the posts permalinks - Moves all pages to non-underscored folders within content/ - Updates config and marks some suspected guides-specific config for later assessment/removal - Gets author pages rendering - Fixes the robots.txt and Google verification pages
This commit: - Moves all author data into single CSV file - Adds CSV as a data format - Incidentally, adds "yml" as a valid YAML file extension - Removes full_name from all authors where full_name = "{first_name} {last_name}" - Sets author page title to full name / computed full name - Sets H1 to full name / computed full name - Removes alum status - it's so out of date it's wrong and not worth fixing - Removes author Markdown pages - Incidentally, moves principles/ into content/pages/ (noticed while moving other files)
This commit: - Removes "author published" status checks - Re-implements team_link and team_photo filters - Re-implements an "authors' matching posts" filter. - Refactors the author post display - Refactors layout into partials - Refactors various author / post display logic - Removes unnecessary (hopefully) context mutation - Fixes author data - Adds missing team member data - Renames authors.csv -> team_members.csv because global data was polluting post.data.authors The consequence of removing the `published` is that we'll have 63 pages for unpublished authors, most/all of whom are team members featured in the "we asked 100 colleagues" posts. These pages are unlinked so no one is likely to stumble upon them by accident. Perhaps we can add a robots.txt entry for them later so they're not indexed. This doesn't have a meaningful impact on performance.
cantsin
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- can confirm it builds.
Side note, I cannot do npm run dev
-- but npm run assets:build
and npm run serve
work fine.
> [email protected] dev
> npm run clean && npm-run-all -p dev:assets dev:serve
> [email protected] clean
> rimraf _site
node:internal/modules/cjs/loader:1146
throw err;
^
Error: Cannot find module './'
beechnut
force-pushed
the
replatform/get-it-building
branch
from
June 4, 2024 22:15
5ffb5f3
to
b625cf0
Compare
There were 176 JavaScript and legacy HTML errors. This commit fixes that. This commit: - Fixes eslint errors, ignoring only the resolution of the csv-parse library. From quick research, this is a common problem. - Fixes HTML validation errors, making tags compliant. (e.g. wraps <figcaption> in <figure>) - Sets the passthrough mode in 11ty. Adding `assets/` as a passthrough caused "not a directory" errors, and setting this mode fixed those errors. - Changes some .md files to .html. Several files were HTML but rendering as Markdown, resulting in the Markdown renderer adding tons of extraneous <p> or </p> tags but not closing them. - Incidentally reorganizes services_projects folder to projects/services/. HTML is not guaranteed to be fully correct.
beechnut
force-pushed
the
replatform/get-it-building
branch
from
June 4, 2024 22:16
b625cf0
to
0e55feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request summary
Closes #3845 and #3847.