Add Chart

[Hjklvfr]

resolve #291

Add Chart with market and pair selection

Use React TS

[Hjklvfr]

Hi @marina-chibizova!
You can check it on https://hjklvfr.github.io/dn-institute/market-health/docs/market-health-metrics/
Some fonts and js files cannot be loaded due to incorrect routing of user pages.

[marina-chibizova]

looks the same for me

[Hjklvfr]

looks the same for me

long loading
I'll add a loader

[evgenydmitriev]

@Hjklvfr, are you planning to address the comment, or we can close this pr?

[Hjklvfr]

@evgenydmitriev
I redid it
made chart support for all metrics
I'm testing now
I'll push it in 1-2 days

[Hjklvfr]

@marina-chibizova @evgenydmitriev
https://hjklvfr.github.io/dn-institute/market-health/docs/market-health-metrics/
I set up the secrets but if it doesn't show up

Bottom 3 charts are displayed after clicking on one of the top chart

[marina-chibizova]

@Hjklvfr cool! Quick notes from my side:

• I still can't render it in a codespace
• Two top charts look different from the rest
• What happens when user clicks on green and blue captions of the top two charts? Why does it affect the results of the charts below?
• Bottom 3 charts are displayed after clicking on one of the top chart - why?

[Hjklvfr]

Short answers from my side:

1. I’ll try to run it myself in codespace and fix the problems
2. I did the first two charts as I see.
   The bottom three charts are made in accordance with the articles in the project.
   3-4. Lower graphs can only appear when a datapoint from the first charts is selected. Because one datapoint have own data for last charts.

[Hjklvfr]

I added secrets for codespaces and fix path of script for codespace. You can reload.

[Hjklvfr]

@marina-chibizova Did what I did matches to what needed to be done?

[marina-chibizova]

@Hjklvfr the thing is it doesn't make much sense to visualize every 1m data point separately. Normally people would plot data over time, like several hours or days to be able to see anomalous spikes. Two top charts make more sense to me. Although putting buy-sell ratio and buy-sell ration absolute on one chart is not that beneficial, since they show the same metric, just a bit differently. These things can be fixed though.

What's more important is how sensible the widget solution is, and how much maintenance would it require. To asset it I would ask @evgenydmitriev for help. If it's fine we can proceed with visualization fixes

[Hjklvfr]

For now I did it without any additional computations. Just api data.
First of all I want to understand is it enough. Because it according articles examples and contains all metrics.
If it needed I can add more logic for aggregate or/and union data. I did base for next steps.
May be it is more sense to sum all 1m first digit metric data(for example).
Every line in plot can be hiden by default or by click on it at bottom.
Also I'm confused about dictionary endpoint. May be it would be more convenient if I can load all pair or markets, or search these. For now it is difficult to switch from one rare pair to another from another market.

[marina-chibizova]

If it needed I can add more logic for aggregate or/and union data. I did base for next steps.
May be it is more sense to sum all 1m first digit metric data(for example).
Every line in plot can be hiden by default or by click on it at bottom.

As I said, all this can be dealt with after we have a green light for service logic

Also I'm confused about dictionary endpoint. May be it would be more convenient if I can load all pair or markets, or search these. For now it is difficult to switch from one rare pair to another from another market.

I didn't quite get what you are saying, /dictionary is very flexible, you can get all the markets at once, or a specific pair with all supported marketvenues or a marketvenue with all supported pairs, or search specific market (unique combination of marketvenue and pair)

[evgenydmitriev]

Comments not addressed. Closing.