Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newbatonid can be nullable #120

Merged
merged 1 commit into from
Mar 29, 2024
Merged

newbatonid can be nullable #120

merged 1 commit into from
Mar 29, 2024

Conversation

milachae
Copy link
Contributor

@milachae milachae commented Mar 28, 2024 •
edited
Loading

Closes #107

@milachae milachae self-assigned this Mar 28, 2024
FKD13
FKD13 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@FKD13 FKD13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks like this also works for DeDenker, so easier than expected 🎉

@FKD13
Copy link
Member

FKD13 commented Mar 29, 2024

closes 12urenloop/DeDenker#8

@FKD13 FKD13 merged commit a85e4d4 into development Mar 29, 2024
1 check passed
@FKD13 FKD13 deleted the newbatonid_nullable branch March 29, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FKD13 FKD13 FKD13 approved these changes

Assignees

@milachae milachae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test switchovers with null batonid's
2 participants
@milachae @FKD13